You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/03 18:46:05 UTC

[GitHub] [arrow-datafusion] retikulum opened a new pull request, #4493: Improve error handling for array downcasting

retikulum opened a new pull request, #4493:
URL: https://github.com/apache/arrow-datafusion/pull/4493

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Discussed in #3152 .
   
   # Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   This is the new PR in a series to improve error handling for downcasting. I think we refactor all parts except macros. My next attempts will be refactoring feasible macros. Those are the macros that use ```is_any().downcast_ref::<$ARRAYTYPE>``` : 
   
   ![image](https://user-images.githubusercontent.com/15185911/205456795-69496947-b865-4994-92f6-0eee67738dcb.png)
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   - Add `as_xxx_array` functions for following types to downcast:
     - `FixedSizeListArray`
     - `FixedSizeBinaryArray`
     - `Date64Array`
     - `GenericStringArray`
   - Refactor parts where old casting schema is used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #4493: Improve error handling for array downcasting

Posted by GitBox <gi...@apache.org>.
alamb merged PR #4493:
URL: https://github.com/apache/arrow-datafusion/pull/4493


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] ursabot commented on pull request #4493: Improve error handling for array downcasting

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4493:
URL: https://github.com/apache/arrow-datafusion/pull/4493#issuecomment-1337855031

   Benchmark runs are scheduled for baseline = b81453e1e372819a375ed2b2b4d49a3598cb7a2a and contender = 5bb9a18563fad4dc9e18b7381c2542e32144f2f1. 5bb9a18563fad4dc9e18b7381c2542e32144f2f1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a45ca81695a54b5984ba09a60f5cf2eb...1e52ebc12b7b4d1d892371b87ec4f75e/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/0b4769229b5a41cabf04f9108cbe3493...a7f4b28c5ecf469e8639244f43ed4e97/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d4d538d4846d473fb22cc7c88a1013aa...79576778a77c4ea8b2b47f479c86c598/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1a003ec17964498a9d75dea380ee228b...dcc73480054a4522b1cf24bf4cca512c/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org