[jira] [Commented] (CAMEL-7046) Base64DataFormat: enable streaming if streamCache=true

["Stephan Siano (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844227#comment-13844227 ] 

Stephan Siano commented on CAMEL-7046:
--------------------------------------

I had already opened https://issues.apache.org/jira/browse/CAMEL-7056 before I saw this. Two things about this patch:

1. special treatment for the urlSafe parameter is not needed in the Base64 decoding case. commons-codec will decode both variants, whether the parameter is set or not.
2. I am not sure if we should only do streaming if stream caching is enabled. There may be use cases when stream caching is not needed but streaming is still a good thing (e.g. read a file, base64 encode it and write it to an ftp server (or vice versa)).

> Base64DataFormat: enable streaming if streamCache=true
> ------------------------------------------------------
>
>                 Key: CAMEL-7046
>                 URL: https://issues.apache.org/jira/browse/CAMEL-7046
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>            Reporter: Franz Forsthofer
>             Fix For: 2.12.3, 2.13.0
>
>         Attachments: 0001-Base64DataFormat-streaming.patch
>
>
> I added streaming to base64 DataFormat. Streaming will be use if streamCache is switched on. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)