You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/12/03 10:36:45 UTC

[GitHub] codecov-io edited a comment on issue #505: SCB-1059 unexpected events publish if error occurs in previous list-watch loop

codecov-io edited a comment on issue #505: SCB-1059 unexpected events publish if error occurs in previous list-watch loop
URL: https://github.com/apache/servicecomb-service-center/pull/505#issuecomment-443663954
 
 
   # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/505?src=pr&el=h1) Report
   > Merging [#505](https://codecov.io/gh/apache/servicecomb-service-center/pull/505?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0e8562ed709191f1543a9b232ad5dc73013632a9?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/505?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #505      +/-   ##
   ==========================================
   + Coverage   59.34%   59.36%   +0.01%     
   ==========================================
     Files         166      166              
     Lines       13945    13945              
   ==========================================
   + Hits         8276     8278       +2     
     Misses       5081     5081              
   + Partials      588      586       -2
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/505?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [server/plugin/pkg/discovery/etcd/cacher\_kv.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY2FjaGVyX2t2Lmdv) | `67.48% <100%> (ø)` | :arrow_up: |
   | [server/broker/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: |
   | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.93% <0%> (+0.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/505?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/505?src=pr&el=footer). Last update [0e8562e...4e022da](https://codecov.io/gh/apache/servicecomb-service-center/pull/505?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services