You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/22 23:51:24 UTC

[GitHub] [solr] epugh opened a new pull request #40: SOLR-15276: Use same pattern on GET as on DELETE and be more RESTful.

epugh opened a new pull request #40:
URL: https://github.com/apache/solr/pull/40


   # Description
   
   Pass the requestid param as the `{id}` in the url, same as in the DELETE verb
   
   # Solution
   
   Simple change to mapper
   
   # Tests
   
   run tests
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ X] I have created a Jira issue and added the issue ID to my pull request title.
   - [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [ X] I have developed this patch against the `main` branch.
   - [ X] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [X ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   
   Docs are being updated in another PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [solr] epugh commented on pull request #40: SOLR-15276: Use same pattern on GET as on DELETE and be more RESTful.

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #40:
URL: https://github.com/apache/solr/pull/40#issuecomment-805028296


   > Agree +1.
   > 
   > Does this need to have an entry in the 9.0 upgrade notes, since the API is changing?
   
   Done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [solr] epugh merged pull request #40: SOLR-15276: Use same pattern on GET as on DELETE and be more RESTful.

Posted by GitBox <gi...@apache.org>.
epugh merged pull request #40:
URL: https://github.com/apache/solr/pull/40


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [solr] gerlowskija commented on pull request #40: SOLR-15276: Use same pattern on GET as on DELETE and be more RESTful.

Posted by GitBox <gi...@apache.org>.
gerlowskija commented on pull request #40:
URL: https://github.com/apache/solr/pull/40#issuecomment-805238992


   A belated LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [solr] HoustonPutman commented on pull request #40: SOLR-15276: Use same pattern on GET as on DELETE and be more RESTful.

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #40:
URL: https://github.com/apache/solr/pull/40#issuecomment-805015063


   Agree +1.
   
   Does this need to have an entry in the 9.0 upgrade notes, since the API is changing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [solr] janhoy commented on pull request #40: SOLR-15276: Use same pattern on GET as on DELETE and be more RESTful.

Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #40:
URL: https://github.com/apache/solr/pull/40#issuecomment-805012184


   I like this change. Let's become more aligned with common REST practices :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org