You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2015/06/10 06:51:52 UTC
[GitHub] storm pull request: STORM-859 Add regression test of STORM-856
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/588
STORM-859 Add regression test of STORM-856
Confirmed that it fails on 27bc183c0f1e33fefb19b640f8a91f563c60ce61 (before merging STORM-856), and succeeds on current master.
Please review and comment. Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-859
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/588.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #588
----
commit 12cd098826dba7a7b3a20bf90341449c5130eab8
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2015-06-10T04:49:13Z
STORM-859 Add regression test of STORM-856
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-859 Add regression test of STORM-856
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/588#issuecomment-116858810
Build failure is coming from storm-kafka since my PR is established before excluding storm-kafka from Travis CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-859 Add regression test of STORM-856
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/588
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-859 Add regression test of STORM-856
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/588#issuecomment-128131583
+1 the change looks great to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---