[jira] [Commented] (PARQUET-1702) [C++] Make BufferedRowGroupWriter compatible with parquet encryption

["Wes McKinney (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988035#comment-16988035 ] 

Wes McKinney commented on PARQUET-1702:
---------------------------------------

[~oro] note you can assign yourself issues on JIRA now

> [C++] Make BufferedRowGroupWriter compatible with parquet encryption
> --------------------------------------------------------------------
>
>                 Key: PARQUET-1702
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1702
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-cpp
>    Affects Versions: cpp-1.6.0
>            Reporter: Or Ozeri
>            Assignee: Or Ozeri
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The newly added parquet encryption feature currently works only with SerializedRowGroupWriter.
> There are several issues preventing the use of BufferedRowGroupWriter with encryption enabled:
> 1. Meta encryptor not passed on to ColumnChunkMetaDataBuilder::Finish. This can trigger a null-pointer dereference (reported as segmentation fault).
> 2. UpdateEncryption not called on Close, resulting in an incorrect AAD string when encrypting the column chunk metadata.
> 3. The column ordinal passed on to PageWriter::Open is always zero, resulting in a wrong AAD string when encrypting the columns data (except for the first column).
> 4. When decrypting a column chunk with no dictionary pages, PARQUET-1706 confuses the decryptor to think it is decrypting a dictionary page, which again causes a wrong AAD string to be used when decrypting.
> We propose a patch (few dozen lines) to fix the above issues.
> We also extend the current parquet-encryption-test unit test, which tests SerializedRowGroupWriter, to test also with BufferedRowGroupWriter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)