You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/12/06 22:24:48 UTC

[kudu-CR] KUDU-1791: tighten up read only usage in log block manager

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5383

to look at the new patch set (#3).

Change subject: KUDU-1791: tighten up read only usage in log block manager
......................................................................

KUDU-1791: tighten up read only usage in log block manager

Over time we had introduced a couple new file deletion/truncation sites that
weren't checking read_only_ before making destructive changes.

This was originally caught by open-fs-readonly-itest. Though exceptionally
rare, it's difficult to conceive of a different test that would surface the
issue more regularly.

Change-Id: I029527b78148d68a002a3c42af5a52f179089a95
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
2 files changed, 41 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/5383/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5383
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I029527b78148d68a002a3c42af5a52f179089a95
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>