You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/13 01:40:01 UTC

[GitHub] [incubator-seatunnel] huzk8 opened a new pull request #1039: [Feature][Plugin] Support Datalake delta #1030

huzk8 opened a new pull request #1039:
URL: https://github.com/apache/incubator-seatunnel/pull/1039

<!--

Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

## Contribution Checklist

- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).

- Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.

- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.

-->

## Purpose of this pull request

this pull request is related to #1030

## Check list

* [x] Code changed are covered with tests, or it does not need tests for reason:
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] RickyHuo commented on a change in pull request #1039: [Feature][Plugin] Support Spark Batch Source/Sink of Datalake delta

Posted by GitBox <gi...@apache.org>.

RickyHuo commented on a change in pull request #1039:
URL: https://github.com/apache/incubator-seatunnel/pull/1039#discussion_r785273634



##########
File path: docs/en/spark/configuration/sink-plugins/Delta.md
##########
@@ -0,0 +1,27 @@
+# Sink plugin: Delta [Spark]
+
+## Description
+
+Write Rows to  Delta Lake.
+
+## Options
+
+| name | type | required | default value | engine |
+| --- | --- | --- | --- | --- |
+| delta.sink.path | string | yes | - | Spark |
+| save_mode	 | string | no | append | Spark |

Review comment:
       You should explain `save_mode` below




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1039: [Feature][Plugin] Support Spark Batch Source/Sink of Datalake delta

Posted by GitBox <gi...@apache.org>.

leo65535 commented on pull request #1039:
URL: https://github.com/apache/incubator-seatunnel/pull/1039#issuecomment-1011687100


   hi @huzk8, can you check the following link, is there an enable button?
   https://github.com/huzk8/seatunnel/actions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] an-shi-chi-fan commented on a change in pull request #1039: [Feature][Plugin] Support Spark Batch Source/Sink of Datalake delta

Posted by GitBox <gi...@apache.org>.

an-shi-chi-fan commented on a change in pull request #1039:
URL: https://github.com/apache/incubator-seatunnel/pull/1039#discussion_r783856039



##########
File path: docs/en/spark/configuration/sink-plugins/Delta.md
##########
@@ -0,0 +1,27 @@
+# Sink plugin: Delta [Spark]
+
+## Description
+
+Write Rows to  Delta Lake.
+
+## Options
+
+| name | type | required | default value | engine |
+| --- | --- | --- | --- | --- |
+| delta.sink.path | string | yes | - | Spark |
+| save_mode	 | string | no | append | Spark |
+
+[More Delta](https://docs.delta.io/0.6.0/delta-batch.html#write-to-a-table)

Review comment:
       is ok to ref other link ? @CalvinKirs 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] huzk8 commented on pull request #1039: [Feature][Plugin] Support Spark Batch Source/Sink of Datalake delta

Posted by GitBox <gi...@apache.org>.

huzk8 commented on pull request #1039:
URL: https://github.com/apache/incubator-seatunnel/pull/1039#issuecomment-1019668394


   @CalvinKirs @RickyHuo  review request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org