[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #1891: [KYUUBI #1867] Support `PlanOnlyStatement` operation like Spark SQL engine

[GitBox <gi...@apache.org>]

SteNicholas commented on a change in pull request #1891:
URL: https://github.com/apache/incubator-kyuubi/pull/1891#discussion_r805595434



##########
File path: externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/operation/ExecuteStatement.scala
##########
@@ -107,10 +105,13 @@ class ExecuteStatement(
       val operation = executor.parseStatement(sessionId, statement)
       operation match {
         case queryOperation: QueryOperation => runQueryOperation(queryOperation)
-        case setOperation: SetOperation => runSetOperation(setOperation)
-        case resetOperation: ResetOperation => runResetOperation(resetOperation)
+        case setOperation: SetOperation =>

Review comment:
       @yanghua, I don't agree with you. If the mode is `NONE`, the `SetOperation` and `ResetOperation` couldn't be executed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org