You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by duncangrant <gi...@git.apache.org> on 2015/02/02 15:24:15 UTC
[GitHub] incubator-brooklyn pull request: Softlayer safe name length
GitHub user duncangrant opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/500
Softlayer safe name length
After extensive testing it would appear that:
- anything up to 55 chars seems to be fine.
- 56-58 characters you could jclouds exceptions while provisioning.
- 59 chars up to around 80 ish you get a provisioned machine with no hostname
- if you set the chars at higher than 100(ish) you get an error saying that the maximum length had been exceeded.
Someone else please test before merging.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/duncangrant/incubator-brooklyn softlayer-safe-name-length
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/500.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #500
----
commit c717cc3fecc8a9c675627a3168e6e6db81a2eb5a
Author: Duncan Grant <du...@cloudsoftcorp.com>
Date: 2015-02-02T09:51:12Z
Revert "fix JcloudsMachineNamer"
This reverts commit 0adda6374c3450c06e7c2a663e8e953941d6afe0.
commit 03054109765aaf9411c12b2cc4c6c32e6433a02f
Author: Duncan Grant <du...@cloudsoftcorp.com>
Date: 2015-02-02T14:20:53Z
Set Softlayer max name length to a tested 55chars
More than this causes different types of error.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Softlayer safe name length
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/500#issuecomment-72480954
@duncangrant Does this mean that the hard limit imposed by SoftLayer is 46 not 55, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Softlayer safe name length
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/500#issuecomment-72633991
Thanks @duncangrant I think it is now more clear!
Yes, the first YAML fails for me as well. The reason seems to be the following:
using the default maxLength=61 - 9 = 52 allowed characters, but jclouds appends and extra suffix of typically 3 chars (*-xy). That means 55 chars which is exactly the limit you found.
Happy to merge your PR, if you could first rebase and squash into one commit only to have a cleaner git history.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Softlayer safe name length
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/500#issuecomment-72480513
@andreaturli
I'm not sure i understand your question. The 9 chars are taken from the length either way so when the custom length is set to 55 then 46 is used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Softlayer safe name length
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/500#issuecomment-72467454
I should Have tried running this with a debugger to see what is going on. I'll let you know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Softlayer safe name length
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/500#issuecomment-72489012
@duncangrant could you please clarify what's the problem with the hostnames in SL with the current master? I've deployed a basic blueprint with jboss and the `hostname` command on the VM returns what I was expecting and `hostname -f` is ok, as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Softlayer safe name length
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/500#issuecomment-72466687
@duncangrant thanks for your analysis but now I'm confused
CloudLocationConfig.VM_NAME_MAX_LENGTH is 61, so without an explicit JcloudsMachineNamer exception for SoftLayer the max length would be 61 - 9 = 52, which is < 55 so it should be ok, according to your testing. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Softlayer safe name length
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/500
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Softlayer safe name length
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/500#issuecomment-72481298
Yes - I should have been clearer. The values I was reporting were the values in the JcloudsMachineNAmer - so the fqdn length not the hostname length
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Softlayer safe name length
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/500#issuecomment-72635156
@andreaturli thanks - Squashed and rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Softlayer safe name length
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/500#issuecomment-72626276
@andreaturli So I think it is something to do with the length of the name of the blueprint. I'll dig into the code a bit but can you confirm that the following yaml fails for you (try your hostname test):
```yaml
name: JBoss7
location: jclouds:softlayer:ams01
services:
- type: brooklyn.entity.webapp.jboss.JBoss7Server
```
whereas the following seems to work:
```yaml
name: jb
location: jclouds:softlayer:ams01
services:
- type: brooklyn.entity.webapp.jboss.JBoss7Server
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---