You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/11/22 05:29:41 UTC
Review Request: Cpuset unit tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8176/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
Description
-------
This adds unit tests for Cpuset.
I'd like to have more integrated tests with CgroupIsolationModule and getcpu:
http://www.kernel.org/doc/man-pages/online/pages/man2/getcpu.2.html
But it's a bit of a bigger undertaking.
Diffs
-----
src/tests/cgroups_isolation_tests.cpp 2685e22eeaf0b764b84e2a6e33e73f75db0515b6
Diff: https://reviews.apache.org/r/8176/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Cpuset unit tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8176/#review13708
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Nov. 22, 2012, 4:29 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8176/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2012, 4:29 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> This adds unit tests for Cpuset.
>
> I'd like to have more integrated tests with CgroupIsolationModule and getcpu:
> http://www.kernel.org/doc/man-pages/online/pages/man2/getcpu.2.html
>
> But it's a bit of a bigger undertaking.
>
>
> Diffs
> -----
>
> src/tests/cgroups_isolation_tests.cpp 2685e22eeaf0b764b84e2a6e33e73f75db0515b6
>
> Diff: https://reviews.apache.org/r/8176/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Cpuset unit tests.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8176/
-----------------------------------------------------------
(Updated Nov. 26, 2012, 6:36 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Style fix from benh review.
Description
-------
This adds unit tests for Cpuset.
I'd like to have more integrated tests with CgroupIsolationModule and getcpu:
http://www.kernel.org/doc/man-pages/online/pages/man2/getcpu.2.html
But it's a bit of a bigger undertaking.
Diffs (updated)
-----
src/tests/cgroups_isolation_tests.cpp 2685e22eeaf0b764b84e2a6e33e73f75db0515b6
Diff: https://reviews.apache.org/r/8176/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Cpuset unit tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8176/#review13717
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 22, 2012, 4:29 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8176/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2012, 4:29 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> This adds unit tests for Cpuset.
>
> I'd like to have more integrated tests with CgroupIsolationModule and getcpu:
> http://www.kernel.org/doc/man-pages/online/pages/man2/getcpu.2.html
>
> But it's a bit of a bigger undertaking.
>
>
> Diffs
> -----
>
> src/tests/cgroups_isolation_tests.cpp 2685e22eeaf0b764b84e2a6e33e73f75db0515b6
>
> Diff: https://reviews.apache.org/r/8176/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Cpuset unit tests.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8176/#review13707
-----------------------------------------------------------
Ship it!
src/tests/cgroups_isolation_tests.cpp
<https://reviews.apache.org/r/8176/#comment29388>
s/foreachpair(/foreachpair (/g
- Benjamin Hindman
On Nov. 22, 2012, 4:29 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8176/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2012, 4:29 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> This adds unit tests for Cpuset.
>
> I'd like to have more integrated tests with CgroupIsolationModule and getcpu:
> http://www.kernel.org/doc/man-pages/online/pages/man2/getcpu.2.html
>
> But it's a bit of a bigger undertaking.
>
>
> Diffs
> -----
>
> src/tests/cgroups_isolation_tests.cpp 2685e22eeaf0b764b84e2a6e33e73f75db0515b6
>
> Diff: https://reviews.apache.org/r/8176/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>