You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/02/01 07:02:20 UTC

[GitHub] sijie commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

sijie commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic
URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r165272868
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -415,6 +415,16 @@ message CommandConsumerStatsResponse {
         optional uint64 msgBacklog                  = 15;
 }
 
+message CommandGetLastMessageId {
 
 Review comment:
   since we are introducing a new command, can you bump the "ProtocolVersion"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services