You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/30 08:05:10 UTC

[GitHub] [apisix-dashboard] imjoey opened a new issue #1155: bug(cmd): Inaccurate output Version number of manger-api command

imjoey opened a new issue #1155:
URL: https://github.com/apache/apisix-dashboard/issues/1155


   # Bug report
   
   ## Describe the bug
   
   When running `manager-api` command generated by the latest code from `master` branch, the output `Version` is `2.2`, which is obviously inaccurate. The log shows as below:
   
   ```
   ➜  apisix-dashboard/output git:(master) ./manager-api
   The manager-api is running successfully!
   
   Version : 2.2
   Listen  : 127.0.0.1:9000
   Loglevel: warn
   Logfile : /Users/imjoey/Work/apache-apisix/apisix-dashboard/output/logs/error.log
   ```
   
   
   ## How to Reproduce
   
   1. Fetch the latest code from master branch;
   2. Run `make build`;
   3. Go into `output` directory and run `./manager-api`;
   4. See error;
   
   ## Expected behavior
   
   The `Version` should be `master`. 
   
   ## System information
   
   - OS: macOS
   - Version: master
   
   ## Additional context
   
   While honestly, the `master` is still **not intuitive**, so shall we also add Git hash into the output? Such as:
   
   ```
   Version : master
   GitHash: 4317a5f
   Listen  : 127.0.0.1:9000
   Loglevel: warn
   Logfile : /Users/imjoey/Work/apache-apisix/apisix-dashboard/output/logs/error.log
   ```
   
   Any feedback is welcome. Thanks.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1155: bug(cmd): Inaccurate output Version number of manger-api command

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1155:
URL: https://github.com/apache/apisix-dashboard/issues/1155


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] imjoey commented on issue #1155: bug(cmd): Inaccurate output Version number of manger-api command

Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1155:
URL: https://github.com/apache/apisix-dashboard/issues/1155#issuecomment-752377734


   @juzhiyuan @starsz OK, thanks for your feedback. I can tackle this. 😃 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1155: bug(cmd): Inaccurate output Version number of manger-api command

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1155:
URL: https://github.com/apache/apisix-dashboard/issues/1155#issuecomment-752372530


   I agree, it's really helpful in the develop branch. @tokers @membphis  right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on issue #1155: bug(cmd): Inaccurate output Version number of manger-api command

Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1155:
URL: https://github.com/apache/apisix-dashboard/issues/1155#issuecomment-752373940


   Agree +1. PR is welcomed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org