You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Herve Boutemy (JIRA)" <ji...@codehaus.org> on 2011/05/08 21:04:22 UTC
[jira] Closed: (MPIR-85) Refactoring of dependency and dependency
management report
[ http://jira.codehaus.org/browse/MPIR-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy closed MPIR-85.
-----------------------------
Resolution: Fixed
Fix Version/s: 2.4
Assignee: Herve Boutemy
with [r1100791|http://svn.apache.org/viewvc?rev=1100791&view=rev], this is the last modification I can see from the patch that can be applied in the actual code
if you have improvements to propose to actual code, please open another issue
> Refactoring of dependency and dependency management report
> ----------------------------------------------------------
>
> Key: MPIR-85
> URL: http://jira.codehaus.org/browse/MPIR-85
> Project: Maven 2.x Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies, dependency-management
> Affects Versions: 2.1
> Reporter: Nick Stolwijk
> Assignee: Herve Boutemy
> Fix For: 2.4
>
> Attachments: comparators.patch, refactor.patch, refactor.patch
>
>
> I've tried to refactor the code from MPIR-83 a bit, because it used a lot of copied code.
> Important improvements:
> - Created a AbstractProjectInfoRenderer and AbstractDependencyRenderer.
> If this patch is accepted, I want to write all the renderers out of the inforeports in separate classes, with more code sharing. This is a start of that.
> - I changed the unit tests, because the expected and actual were reversed. This is the case in many of the info report unit tests.
> Please tell me what you think of it. I know it is only a start.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira