You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/06/24 10:47:36 UTC

[GitHub] [couchdb] iilyak commented on a change in pull request #3638: Improve handling of + in URLs

iilyak commented on a change in pull request #3638:
URL: https://github.com/apache/couchdb/pull/3638#discussion_r657837262



##########
File path: src/couch/src/couch_util.erl
##########
@@ -795,3 +808,20 @@ hmac(Alg, Key, Message) ->
     crypto:hmac(Alg, Key, Message).
 
 -endif. % -ifdef(OTP_RELEASE)
+
+unquote(Binary) when is_binary(Binary) ->
+    unquote(binary_to_list(Binary));
+unquote(String) ->
+    qs_revdecode(lists:reverse(String)).
+
+qs_revdecode(S) ->
+    qs_revdecode(S, []).
+
+qs_revdecode([], Acc) ->
+    Acc;
+qs_revdecode([$+ | Rest], Acc) ->

Review comment:
       We don't need this clause since this case would be handled on line 826.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org