[GitHub] [spark] maropu commented on a change in pull request #25243: [SPARK-28498][SQL][TEST] always create a fresh copy of the SparkSession before each test

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #25243: [SPARK-28498][SQL][TEST] always create a fresh copy of the SparkSession before each test
URL: https://github.com/apache/spark/pull/25243#discussion_r307259052
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
 ##########
 @@ -2061,17 +2043,16 @@ class DataFrameSuite extends QueryTest with SharedSQLContext {
   }
 
   test("SPARK-24781: Using a reference not in aggregation in Filter/Sort") {
-     withSQLConf(SQLConf.DATAFRAME_RETAIN_GROUP_COLUMNS.key -> "false") {
-      val df = Seq(("test1", 0), ("test2", 1)).toDF("name", "id")
+    spark.sessionState.conf.setConf(SQLConf.DATAFRAME_RETAIN_GROUP_COLUMNS, false)
 
 Review comment:
   nit: how about defining a short name (e.g., `setConf`?) for `spark.sessionState.conf.setConf` in `SharedSparkSessionWithFreshCopy`?  (`spark.sessionState.conf.setConf` is long for typing in...)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org