You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by asdf2014 <gi...@git.apache.org> on 2017/06/16 07:38:11 UTC
[GitHub] zookeeper pull request #283: MINOR: 1. Fix streamsToFlush not completely emp...
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/283
MINOR: 1. Fix streamsToFlush not completely empty problem; 2. Using try clause to close resource; 3. Others code refactoring for PERSISTENCE module
MINOR:
* Fix streamsToFlush not completely empty problem;
* Using try clause to close resource;
* Others code refactoring for PERSISTENCE module.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/asdf2014/zookeeper code_refactoring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/283.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #283
----
commit 19bbfe324f61f2794283f7d3683a7260cd6c5e41
Author: asdf2014 <15...@qq.com>
Date: 2017-05-24T06:02:49Z
MINOR: 1. Fix streamsToFlush not completely empty problem; 2. Using try clause to close resource; 3. Others code refactoring for PERSISTENCE module
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #283: MINOR: 1. Using try clause to close resource; 2. Other...
Posted by asdf2014 <gi...@git.apache.org>.
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/283
Hi, @hanm . I got it and i will create the jira. Sorry for bring the `MINOR` habit from Apache Eagle..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #283: ZOOKEEPER-2815: 1. Using try clause to close resource;...
Posted by asdf2014 <gi...@git.apache.org>.
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/283
@hanm Already done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #283: ZOOKEEPER-2815: 1. Using try clause to close resource;...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/283
Merged, thanks @asdf2014.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #283: ZOOKEEPER-2815: 1. Using try clause to close re...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/283
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #283: MINOR: 1. Using try clause to close resource; 2. Other...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/283
@asdf2014 : Thanks for spending time refactoring the code base.
Please first file a JIRA and then make a pull request with the JIRA number in the PR title or description. We requires this so the changes can be tracked and kept records on Apache side. Please also checkout https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #283: ZOOKEEPER-2815: 1. Using try clause to close resource;...
Posted by asdf2014 <gi...@git.apache.org>.
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/283
@hanm You are welcome :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #283: ZOOKEEPER-2815: 1. Using try clause to close resource;...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/283
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---