You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Taragolis (via GitHub)" <gi...@apache.org> on 2023/08/31 13:51:10 UTC
[GitHub] [airflow] Taragolis opened a new pull request, #33960: Make `aws.session_factory` part of Amazon provider configuration
Taragolis opened a new pull request, #33960:
URL: https://github.com/apache/airflow/pull/33960
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Add `[aws] session_factory` part of AWS Documentation. This configuration option added in https://github.com/apache/airflow/pull/21778 and 3.1.1 version of provider.
This PR doesn't add it in [global configuration reference](https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#configuration-reference), better add after documentation to Amazon Provider updated, so we do not have missing link in documentation
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Lee-W commented on a diff in pull request #33960: Make `aws.session_factory` part of Amazon provider configuration documentation
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #33960:
URL: https://github.com/apache/airflow/pull/33960#discussion_r1312415063
##########
airflow/providers/amazon/provider.yaml:
##########
@@ -710,3 +710,16 @@ additional-extras:
- name: cncf.kubernetes
dependencies:
- apache-airflow-providers-cncf-kubernetes>=7.2.0
+
+config:
+ aws:
+ description: This section applies settings for Amazon Web Services (AWS) integration.
+ options:
+ session_factory:
+ description: |
+ Full import path to the class which implements custom session factory for ``boto3.session.Session``,
+ for more detail please have a look at :ref:`howto/connection:aws:session-factory`.
+ default: ~
+ example: my_company.aws.MyCustomSessionFactory
+ type: string
+ version_added: ~
Review Comment:
If that is the case, should we add a check to make sure this value is not higher than the latest airflow version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #33960: Make `aws.session_factory` part of Amazon provider configuration documentation
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on PR #33960:
URL: https://github.com/apache/airflow/pull/33960#issuecomment-1702838802
Converted to draft, for prevent merge it before #34011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #33960: Make `aws.session_factory` part of Amazon provider configuration documentation
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #33960:
URL: https://github.com/apache/airflow/pull/33960#discussion_r1312748153
##########
airflow/providers/amazon/provider.yaml:
##########
@@ -710,3 +710,16 @@ additional-extras:
- name: cncf.kubernetes
dependencies:
- apache-airflow-providers-cncf-kubernetes>=7.2.0
+
+config:
+ aws:
+ description: This section applies settings for Amazon Web Services (AWS) integration.
+ options:
+ session_factory:
+ description: |
+ Full import path to the class which implements custom session factory for ``boto3.session.Session``,
+ for more detail please have a look at :ref:`howto/connection:aws:session-factory`.
+ default: ~
+ example: my_company.aws.MyCustomSessionFactory
+ type: string
+ version_added: ~
Review Comment:
I guess it is additional validation just in case for Airflow Core
E.g.: option would added to 2.8, but in 2.7.x it do not make any affect on configuration side .
https://github.com/apache/airflow/blob/b82ce61285f3f4f0c7eccb2c3effaef53c9fb84e/airflow/configuration.py#L571-L576
And this remove futures configs, during generation documentatio
https://github.com/apache/airflow/blob/2663b177a666ee150f86bd16ad51526319fa7adb/docs/conf.py#L434-L442
In general this logic designed in the time, when providers doesn't have their own documentation for configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vincbeck merged pull request #33960: Make `aws.session_factory` part of Amazon provider configuration documentation
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #33960:
URL: https://github.com/apache/airflow/pull/33960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on a diff in pull request #33960: Make `aws.session_factory` part of Amazon provider configuration documentation
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #33960:
URL: https://github.com/apache/airflow/pull/33960#discussion_r1312320477
##########
airflow/providers/amazon/provider.yaml:
##########
@@ -710,3 +710,16 @@ additional-extras:
- name: cncf.kubernetes
dependencies:
- apache-airflow-providers-cncf-kubernetes>=7.2.0
+
+config:
+ aws:
+ description: This section applies settings for Amazon Web Services (AWS) integration.
+ options:
+ session_factory:
+ description: |
+ Full import path to the class which implements custom session factory for ``boto3.session.Session``,
+ for more detail please have a look at :ref:`howto/connection:aws:session-factory`.
Review Comment:
Just a minor nit:
```suggestion
Full import path to the class which implements a custom session factory for ``boto3.session.Session``.
For more details please have a look at :ref:`howto/connection:aws:session-factory`.
```
##########
airflow/providers/amazon/provider.yaml:
##########
@@ -710,3 +710,16 @@ additional-extras:
- name: cncf.kubernetes
dependencies:
- apache-airflow-providers-cncf-kubernetes>=7.2.0
+
+config:
+ aws:
+ description: This section applies settings for Amazon Web Services (AWS) integration.
Review Comment:
Maybe contains instead of applies?
```suggestion
description: This section contains settings for Amazon Web Services (AWS) integration.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #33960: Make `aws.session_factory` part of Amazon provider configuration
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #33960:
URL: https://github.com/apache/airflow/pull/33960#discussion_r1311667803
##########
airflow/providers/amazon/provider.yaml:
##########
@@ -710,3 +710,16 @@ additional-extras:
- name: cncf.kubernetes
dependencies:
- apache-airflow-providers-cncf-kubernetes>=7.2.0
+
+config:
+ aws:
+ description: This section applies settings for Amazon Web Services (AWS) integration.
+ options:
+ session_factory:
+ description: |
+ Full import path to the class which implements custom session factory for ``boto3.session.Session``,
+ for more detail please have a look at :ref:`howto/connection:aws:session-factory`.
+ default: ~
+ example: my_company.aws.MyCustomSessionFactory
+ type: string
+ version_added: ~
Review Comment:
Seem like this field expected Airflow Version rather than Provider version.
When I tried to add `3.1.1` the record was gone from documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org