You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "bluedavy (Created) (JIRA)" <ji...@apache.org> on 2011/10/10 05:14:29 UTC

[jira] [Created] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
---------------------------------------------------------------------------------------------------------

                 Key: HBASE-4563
                 URL: https://issues.apache.org/jira/browse/HBASE-4563
             Project: HBase
          Issue Type: Bug
    Affects Versions: 0.90.4
            Reporter: bluedavy
            Priority: Blocker
             Fix For: 0.90.5


Follow below steps to replay the problem:
1. change the SplitTransaction.java as below,just like mock the hdfs error.
   {code:title=SplitTransaction.java|borderStyle=solid}
      List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
      throw new IOException("some unexpected error in close store files");
   {code} 
2. update the regionserver code,restart;
3. create a table & put some data to the table;
4. split the table;
5. scan the table,then it'll fail.

We can fix the bug just use below code:
{code:title=SplitTransaction.java|borderStyle=solid}
      List<StoreFile> hstoreFilesToSplit = null;
      try{
          hstoreFilesToSplit = this.parent.close(false);
      }
      catch(IOException  e){
          this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
          throw e;
      }
{code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment: HBASE-4563fortrunk.patch
                HBASE-4563for0.92.patch
    
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-test.report.txt, HBASE-4563.patch, HBASE-4563for0.92.patch, HBASE-4563fortrunk.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Component/s: regionserver
    
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4562&4563.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use below code:
> {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = null;
>       try{
>           hstoreFilesToSplit = this.parent.close(false);
>       }
>       catch(IOException  e){
>           this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
>           throw e;
>       }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128350#comment-13128350 ] 

Lars Hofhansl commented on HBASE-4563:
--------------------------------------

+1 on patches (pending all tests pass and Ted's suggested formatting fix).
                
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124744#comment-13124744 ] 

ramkrishna.s.vasudevan commented on HBASE-4563:
-----------------------------------------------

{code}
+      }
+	} finally {
+      this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
{code}
Formatting issue is there in the latest patch

HBASE-4563fortrunk.patch and HBASE-4563for0.92.patch.  If you submit for trunk the same can be taken for 0.92. I will leave it to others for commenting before we can commit.





                
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-test.report.txt, HBASE-4563.patch, HBASE-4563for0.92.patch, HBASE-4563fortrunk.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment:     (was: HBASE-4563fortrunk.patch)
    
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128660#comment-13128660 ] 

Lars Hofhansl commented on HBASE-4563:
--------------------------------------

@Ted... You wanna commit, or should I? I'm happy to.
                
> When error occurs in this.parent.close(false) of split, the split region cannot write or read
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Assignee: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128665#comment-13128665 ] 

Ted Yu commented on HBASE-4563:
-------------------------------

@Lars:
Go ahead.
                
> When error occurs in this.parent.close(false) of split, the split region cannot write or read
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Assignee: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128709#comment-13128709 ] 

Hudson commented on HBASE-4563:
-------------------------------

Integrated in HBase-TRUNK #2329 (See [https://builds.apache.org/job/HBase-TRUNK/2329/])
    HBASE-4563  When error occurs in this.parent.close(false) of split, the split region cannot write or read

larsh : 
Files : 
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java

                
> When error occurs in this.parent.close(false) of split, the split region cannot write or read
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Assignee: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment:     (was: HBASE-4563.patch)
    
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124635#comment-13124635 ] 

bluedavy commented on HBASE-4563:
---------------------------------

@Ted Yu
Yes,:),I'll change it & attach the patch again.
                
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-test.report.txt, HBASE-4563.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use below code:
> {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = null;
>       try{
>           hstoreFilesToSplit = this.parent.close(false);
>       }
>       catch(IOException  e){
>           this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
>           throw e;
>       }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

Posted by "bluedavy (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128575#comment-13128575 ] 

bluedavy commented on HBASE-4563:
---------------------------------

I fix the formatter.
                
> When error occurs in this.parent.close(false) of split, the split region cannot write or read
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Assignee: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment: HBASE-4563.patch
    
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-test.report.txt, HBASE-4563.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use below code:
> {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = null;
>       try{
>           hstoreFilesToSplit = this.parent.close(false);
>       }
>       catch(IOException  e){
>           this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
>           throw e;
>       }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment:     (was: HBASE-4563-0.90.patch)
    
> When error occurs in this.parent.close(false) of split, the split region cannot write or read
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Assignee: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124626#comment-13124626 ] 

bluedavy commented on HBASE-4563:
---------------------------------

throw exception so CompactSplitThread can catch it then do rollback...
                
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-test.report.txt, HBASE-4563.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use below code:
> {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = null;
>       try{
>           hstoreFilesToSplit = this.parent.close(false);
>       }
>       catch(IOException  e){
>           this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
>           throw e;
>       }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment: HBASE-4562&4563.patch
    
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4562&4563.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use below code:
> {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = null;
>       try{
>           hstoreFilesToSplit = this.parent.close(false);
>       }
>       catch(IOException  e){
>           this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
>           throw e;
>       }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment:     (was: HBASE-4562&4563.patch)
    
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use below code:
> {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = null;
>       try{
>           hstoreFilesToSplit = this.parent.close(false);
>       }
>       catch(IOException  e){
>           this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
>           throw e;
>       }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128742#comment-13128742 ] 

Hudson commented on HBASE-4563:
-------------------------------

Integrated in HBase-0.92 #66 (See [https://builds.apache.org/job/HBase-0.92/66/])
    HBASE-4563  When error occurs in this.parent.close(false) of split, the split region cannot write or read

larsh : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java

                
> When error occurs in this.parent.close(false) of split, the split region cannot write or read
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Assignee: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123992#comment-13123992 ] 

ramkrishna.s.vasudevan commented on HBASE-4563:
-----------------------------------------------

Is it possible to write a testcase with the scenario you have told in the description?

Minor comment.
{code}
+	}
+	catch(IOException e){
+	  throw e;
+	}
+	finally{
{code}

Catch block, finally block should start in the same line like
+	} catch(IOException e){
+	  throw e;
+	} finally{

                
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-test.report.txt, HBASE-4563.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use below code:
> {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = null;
>       try{
>           hstoreFilesToSplit = this.parent.close(false);
>       }
>       catch(IOException  e){
>           this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
>           throw e;
>       }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

Posted by "bluedavy (Reopened) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy reopened HBASE-4563:
-----------------------------


wait for committer commit to the svn.
                
> When error occurs in this.parent.close(false) of split, the split region cannot write or read
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Assignee: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment:     (was: HBASE-4563-test.report.txt)
    
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment: HBASE-4563-trunk.patch
                HBASE-4563-0.92.patch
                HBASE-4563-0.90.patch
    
> When error occurs in this.parent.close(false) of split, the split region cannot write or read
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Assignee: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

Posted by "Lars Hofhansl (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl resolved HBASE-4563.
----------------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed

Committed to 0.90, 0.92, and trunk
                
> When error occurs in this.parent.close(false) of split, the split region cannot write or read
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Assignee: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment:     (was: HBASE-4563-trunk.patch)
    
> When error occurs in this.parent.close(false) of split, the split region cannot write or read
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Assignee: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124751#comment-13124751 ] 

Ted Yu commented on HBASE-4563:
-------------------------------

Please run through unit tests for 0.92 patch.
                
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-test.report.txt, HBASE-4563.patch, HBASE-4563for0.92.patch, HBASE-4563fortrunk.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123990#comment-13123990 ] 

ramkrishna.s.vasudevan commented on HBASE-4563:
-----------------------------------------------

Thanks for the patch.
{code}
+	catch(IOException e){
+	  throw e;
+	}

{code}
Why should we catch and again throw exception?
                
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-test.report.txt, HBASE-4563.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use below code:
> {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = null;
>       try{
>           hstoreFilesToSplit = this.parent.close(false);
>       }
>       catch(IOException  e){
>           this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
>           throw e;
>       }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment:     (was: HBASE-4563.patch)
    
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-test.report.txt, HBASE-4563.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use below code:
> {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = null;
>       try{
>           hstoreFilesToSplit = this.parent.close(false);
>       }
>       catch(IOException  e){
>           this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
>           throw e;
>       }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write & read

Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-4563:
--------------------------

    Summary: When error occurs in this.parent.close(false) of split, the split region cannot write & read  (was: When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read)
    
> When error occurs in this.parent.close(false) of split, the split region cannot write & read
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment: HBASE-4563-test.report.txt
                HBASE-4563.patch

patch & test report.
                
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-test.report.txt, HBASE-4563.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use below code:
> {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = null;
>       try{
>           hstoreFilesToSplit = this.parent.close(false);
>       }
>       catch(IOException  e){
>           this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
>           throw e;
>       }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment: test-4563-trunk.txt
                test-4563-0.92.txt
                test-4563-0.90.txt
                HBASE-4563-trunk.patch
                HBASE-4563-0.92.patch
                HBASE-4563-0.90.patch
    
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-4563:
--------------------------

    Assignee: bluedavy
     Summary: When error occurs in this.parent.close(false) of split, the split region cannot write or read  (was: When error occurs in this.parent.close(false) of split, the split region cannot write & read)
    
> When error occurs in this.parent.close(false) of split, the split region cannot write or read
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Assignee: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Affects Version/s: 0.92.0
    
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-test.report.txt, HBASE-4563.patch, HBASE-4563for0.92.patch, HBASE-4563fortrunk.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128327#comment-13128327 ] 

Ted Yu commented on HBASE-4563:
-------------------------------

Thanks for the detailed test report.
+1 on patches.
There is some formatting:
{code}
+	} finally {
+      this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
+	}
{code}
The right curly brace before finally should be moved left by 3 spaces.
Same with the closing right curly brace.

See HBASE-3678 for Formatter for Eclipse.
                
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124630#comment-13124630 ] 

Ted Yu commented on HBASE-4563:
-------------------------------

Ramkrishna's comment @ 10/Oct/11 10:35 was saying that the IOException caught didn't get transformed into another exception type.
So the catch block isn't needed.
                
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-test.report.txt, HBASE-4563.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use below code:
> {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = null;
>       try{
>           hstoreFilesToSplit = this.parent.close(false);
>       }
>       catch(IOException  e){
>           this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
>           throw e;
>       }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

Posted by "bluedavy (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy resolved HBASE-4563.
-----------------------------

    Resolution: Fixed
    
> When error occurs in this.parent.close(false) of split, the split region cannot write or read
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Assignee: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment:     (was: HBASE-4563for0.92.patch)
    
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Attachment:     (was: HBASE-4563-0.92.patch)
    
> When error occurs in this.parent.close(false) of split, the split region cannot write or read
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: bluedavy
>            Assignee: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

Posted by "bluedavy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bluedavy updated HBASE-4563:
----------------------------

    Description: 
Follow below steps to replay the problem:
1. change the SplitTransaction.java as below,just like mock the hdfs error.
   {code:title=SplitTransaction.java|borderStyle=solid}
      List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
      throw new IOException("some unexpected error in close store files");
   {code} 
2. update the regionserver code,restart;
3. create a table & put some data to the table;
4. split the table;
5. scan the table,then it'll fail.

We can fix the bug just use the patch.

  was:
Follow below steps to replay the problem:
1. change the SplitTransaction.java as below,just like mock the hdfs error.
   {code:title=SplitTransaction.java|borderStyle=solid}
      List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
      throw new IOException("some unexpected error in close store files");
   {code} 
2. update the regionserver code,restart;
3. create a table & put some data to the table;
4. split the table;
5. scan the table,then it'll fail.

We can fix the bug just use below code:
{code:title=SplitTransaction.java|borderStyle=solid}
      List<StoreFile> hstoreFilesToSplit = null;
      try{
          hstoreFilesToSplit = this.parent.close(false);
      }
      catch(IOException  e){
          this.journal.add(JournalEntry.CLOSED_PARENT_REGION);
          throw e;
      }
{code} 

    
> When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4563
>                 URL: https://issues.apache.org/jira/browse/HBASE-4563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4563-test.report.txt, HBASE-4563.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the hdfs error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       List<StoreFile> hstoreFilesToSplit = this.parent.close(false);
>       throw new IOException("some unexpected error in close store files");
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. scan the table,then it'll fail.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira