You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/17 01:17:36 UTC
[GitHub] [incubator-eventmesh] jonyangx opened a new pull request, #2616: [ISSUE #2601] Method calls equals on an enum instance [MessageTransferTask]
jonyangx opened a new pull request, #2616:
URL: https://github.com/apache/incubator-eventmesh/pull/2616
Fixes #2601 .
### Motivation
Method calls equals on an enum instance [MessageTransferTask]
### Modifications
refactor
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java AbstractTask.java and sub Classes.
### Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #2616: [ISSUE #2601] Method calls equals on an enum instance [MessageTransferTask]
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2616:
URL: https://github.com/apache/incubator-eventmesh/pull/2616#issuecomment-1356791091
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/2616?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2616](https://codecov.io/gh/apache/incubator-eventmesh/pull/2616?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0af1204) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/fd181e8805e5e0b31eae2f4e830c9de21f9d14a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fd181e8) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #2616 +/- ##
============================================
- Coverage 11.83% 11.82% -0.01%
Complexity 900 900
============================================
Files 476 476
Lines 27198 27205 +7
Branches 2814 2813 -1
============================================
- Hits 3219 3218 -1
- Misses 23691 23699 +8
Partials 288 288
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/2616?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...me/core/protocol/tcp/client/task/AbstractTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL0Fic3RyYWN0VGFzay5qYXZh) | `0.00% <ø> (ø)` | |
| [...ime/core/protocol/tcp/client/task/GoodbyeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL0dvb2RieWVUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/core/protocol/tcp/client/task/HeartBeatTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL0hlYXJ0QmVhdFRhc2suamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ntime/core/protocol/tcp/client/task/HelloTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL0hlbGxvVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...time/core/protocol/tcp/client/task/ListenTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL0xpc3RlblRhc2suamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../core/protocol/tcp/client/task/MessageAckTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL01lc3NhZ2VBY2tUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../protocol/tcp/client/task/MessageTransferTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL01lc3NhZ2VUcmFuc2ZlclRhc2suamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/core/protocol/tcp/client/task/RecommendTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL1JlY29tbWVuZFRhc2suamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/core/protocol/tcp/client/task/SubscribeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL1N1YnNjcmliZVRhc2suamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...core/protocol/tcp/client/task/UnSubscribeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL1VuU3Vic2NyaWJlVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/2616/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #2616: [ISSUE #2601] Method calls equals on an enum instance [MessageTransferTask]
Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #2616:
URL: https://github.com/apache/incubator-eventmesh/pull/2616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org