You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by mb...@apache.org on 2006/09/28 00:32:11 UTC

svn commit: r450606 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Concat.java

Author: mbenson
Date: Wed Sep 27 15:32:07 2006
New Revision: 450606

URL: http://svn.apache.org/viewvc?view=rev&rev=450606
Log:
remove unnecessary parens

Modified:
    ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Concat.java

Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Concat.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Concat.java?view=diff&rev=450606&r1=450605&r2=450606
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Concat.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Concat.java Wed Sep 27 15:32:07 2006
@@ -252,7 +252,7 @@
      * @since Ant 1.7
      */
     public void add(ResourceCollection c) {
-        rc = (rc == null) ? new Resources() : rc;
+        rc = rc == null ? new Resources() : rc;
         rc.add(c);
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: svn commit: r450606 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Concat.java

Posted by Dominique Devienne <dd...@gmail.com>.
> remove unnecessary parens
> -        rc = (rc == null) ? new Resources() : rc;
> +        rc = rc == null ? new Resources() : rc;

Do you really think it reads better? I personally refuse operator
precedence to rule my life ;-) --DD

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org