You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2026/10/12 04:14:11 UTC
[PR] [refine](be) Remove redundant column pointer conversions [doris]
Mryange opened a new pull request, #68933:
URL: https://github.com/apache/doris/pull/68933
### What problem does this PR solve?
Several BE paths converted an existing column pointer to a new intrusive pointer and immediately extracted the raw pointer with `get_ptr().get()`. These conversions do not copy column data, but obscure ownership and add unnecessary pointer operations.
This change uses existing `ColumnPtr` values or direct borrowed references where the parent column already guarantees lifetime. JSON readers keep explicit `MutableColumnPtr` owners while passing mutable raw pointers to synchronous deserialization calls.
Related PR: #68880
### Release note
None
### Check List (For Author)
- Test: No build or tests run; source-only pointer ownership cleanup
- Behavior changed: No
- Does this need documentation: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](be) Remove redundant column pointer conversions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68933:
URL: https://github.com/apache/doris/pull/68933#issuecomment-6118436165
<details>
<summary>TPC-H: <b>Total hot run time: 29058 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit abef12928356a8001946dd00ddf0e3d7b20ae746, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17597 5663 5563 5563
q2 2110 307 250 250
q3 10230 1399 874 874
q4 4694 478 348 348
q5 7464 814 542 542
q6 192 192 163 163
q7 780 806 608 608
q8 9264 1352 1186 1186
q9 5698 4457 4452 4452
q10 6825 1270 1024 1024
q11 432 256 239 239
q12 639 407 290 290
q13 18035 3068 2389 2389
q14 289 269 246 246
q15 q16 744 732 659 659
q17 1191 741 586 586
q18 7127 6250 6223 6223
q19 1261 981 625 625
q20 386 350 233 233
q21 5838 2291 2447 2291
q22 365 322 267 267
Total cold run time: 101161 ms
Total hot run time: 29058 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 6136 6121 6153 6121
q2 696 600 555 555
q3 5232 5409 4931 4931
q4 2030 2160 1570 1570
q5 5264 5553 6030 5553
q6 261 204 156 156
q7 2390 2121 1868 1868
q8 3272 3059 2795 2795
q9 8311 8238 8384 8238
q10 3747 3733 3311 3311
q11 624 433 415 415
q12 697 733 537 537
q13 2889 3148 2518 2518
q14 299 312 302 302
q15 q16 728 762 649 649
q17 8543 7529 7566 7529
q18 13156 12322 13191 12322
q19 967 859 866 859
q20 2251 2207 1971 1971
q21 6251 4802 4866 4802
q22 487 438 420 420
Total cold run time: 74231 ms
Total hot run time: 67422 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](be) Remove redundant column pointer conversions [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #68933:
URL: https://github.com/apache/doris/pull/68933#issuecomment-6137279391
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](be) Remove redundant column pointer conversions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68933:
URL: https://github.com/apache/doris/pull/68933#issuecomment-6120319545
# BE UT Coverage Report
Increment line coverage `12.50% (1/8)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/abef12928356a8001946dd00ddf0e3d7b20ae746_abef12928356a8001946dd00ddf0e3d7b20ae746/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/abef12928356a8001946dd00ddf0e3d7b20ae746_abef12928356a8001946dd00ddf0e3d7b20ae746/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 65.63% (31249/47612) |
| Line Coverage | 50.36% (328596/652486) |
| Region Coverage | 45.73% (265353/580250) |
| Branch Coverage | 47.40% (124590/262826) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](be) Remove redundant column pointer conversions [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #68933:
URL: https://github.com/apache/doris/pull/68933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](be) Remove redundant column pointer conversions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68933:
URL: https://github.com/apache/doris/pull/68933#issuecomment-6117625498
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](be) Remove redundant column pointer conversions [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #68933:
URL: https://github.com/apache/doris/pull/68933#issuecomment-6137279926
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](be) Remove redundant column pointer conversions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68933:
URL: https://github.com/apache/doris/pull/68933#issuecomment-6118539797
<details>
<summary>TPC-DS: <b>Total hot run time: 152075 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit abef12928356a8001946dd00ddf0e3d7b20ae746, data reload: false
query5 4312 602 456 456
query6 420 205 191 191
query7 4814 441 229 229
query8 322 190 174 174
query9 8757 4041 4020 4020
query10 479 310 249 249
query11 5974 3405 3195 3195
query12 150 88 85 85
query13 1244 447 323 323
query14 6552 4788 4526 4526
query14_1 4291 4329 4231 4231
query15 211 200 179 179
query16 955 449 427 427
query17 873 686 572 572
query18 2428 398 304 304
query19 183 160 124 124
query20 79 76 76 76
query21 212 134 113 113
query22 12945 13070 12805 12805
query23 13173 12542 12114 12114
query23_1 12256 12082 12084 12082
query24 7119 862 454 454
query24_1 469 466 455 455
query25 501 383 336 336
query26 1257 256 135 135
query27 2783 435 269 269
query28 4644 1929 1921 1921
query29 1542 589 444 444
query30 288 213 180 180
query31 888 767 641 641
query32 160 95 83 83
query33 488 305 259 259
query34 1019 842 498 498
query35 740 772 653 653
query36 820 798 728 728
query37 126 101 87 87
query38 1779 1771 1661 1661
query39 737 749 692 692
query39_1 647 678 674 674
query40 214 150 96 96
query41 69 65 64 64
query42 85 88 81 81
query43 380 379 333 333
query44 1334 697 694 694
query45 182 173 165 165
query46 853 957 567 567
query47 2996 2996 2902 2902
query48 290 300 212 212
query49 561 398 289 289
query50 694 283 219 219
query51 10305 10626 10221 10221
query52 81 81 71 71
query53 191 210 152 152
query54 252 202 193 193
query55 70 66 62 62
query56 233 209 224 209
query57 1615 1585 1546 1546
query58 281 261 254 254
query59 2349 2391 2125 2125
query60 291 236 220 220
query61 146 144 143 143
query62 395 341 290 290
query63 204 157 176 157
query64 2715 929 886 886
query65 3444 3385 3395 3385
query66 1804 440 315 315
query67 20167 20381 20027 20027
query68 3010 1008 626 626
query69 390 298 259 259
query70 925 838 851 838
query71 297 242 229 229
query72 2836 2681 2444 2444
query73 545 555 299 299
query74 4610 4487 4316 4316
query75 2367 2354 1949 1949
query76 2290 1039 622 622
query77 359 401 298 298
query78 9038 9084 8503 8503
query79 989 895 518 518
query80 704 418 356 356
query81 555 329 273 273
query82 1023 138 107 107
query83 285 197 181 181
query84 322 123 102 102
query85 860 432 360 360
query86 326 239 229 229
query87 2029 1950 1856 1856
query88 3684 2705 2653 2653
query89 347 295 258 258
query90 1864 189 186 186
query91 158 152 121 121
query92 97 86 88 86
query93 1026 997 562 562
query94 455 314 286 286
query95 597 413 318 318
query96 679 517 232 232
query97 2421 2408 2308 2308
query98 157 145 145 145
query99 777 774 653 653
Total cold run time: 234483 ms
Total hot run time: 152075 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](be) Remove redundant column pointer conversions [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68933:
URL: https://github.com/apache/doris/pull/68933#issuecomment-6117982676
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](be) Remove redundant column pointer conversions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68933:
URL: https://github.com/apache/doris/pull/68933#issuecomment-6120466731
# BE Regression && UT Coverage Report
Increment line coverage `25.00% (2/8)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/68933_abef12928356a8001946dd00ddf0e3d7b20ae746_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/68933_abef12928356a8001946dd00ddf0e3d7b20ae746_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 76.89% (35440/46090) |
| Line Coverage | 62.12% (400741/645134) |
| Region Coverage | 58.49% (337975/577849) |
| Branch Coverage | 59.40% (155632/262017) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](be) Remove redundant column pointer conversions [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68933:
URL: https://github.com/apache/doris/pull/68933#issuecomment-6118063907
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](be) Remove redundant column pointer conversions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68933:
URL: https://github.com/apache/doris/pull/68933#issuecomment-6118590078
<details>
<summary>ClickBench: <b>Total hot run time: 24.62 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit abef12928356a8001946dd00ddf0e3d7b20ae746, data reload: false
query1 0.00 0.00 0.01
query2 0.10 0.05 0.05
query3 0.27 0.11 0.11
query4 1.61 0.13 0.13
query5 0.28 0.22 0.26
query6 1.17 0.67 0.68
query7 0.04 0.01 0.00
query8 0.05 0.04 0.04
query9 0.42 0.35 0.36
query10 0.61 0.56 0.57
query11 0.21 0.15 0.14
query12 0.18 0.15 0.15
query13 0.51 0.50 0.50
query14 0.97 0.97 0.95
query15 0.65 0.62 0.61
query16 0.35 0.35 0.32
query17 1.13 1.19 1.15
query18 0.24 0.21 0.21
query19 2.08 2.03 1.98
query20 0.02 0.02 0.01
query21 15.55 0.27 0.15
query22 4.45 0.06 0.06
query23 16.24 0.33 0.12
query24 2.87 0.67 0.48
query25 0.13 0.04 0.07
query26 1.74 0.24 0.15
query27 0.06 0.05 0.03
query28 2.63 0.66 0.41
query29 12.49 4.23 3.32
query30 0.29 0.15 0.13
query31 2.77 0.59 0.35
query32 3.22 0.63 0.51
query33 3.18 3.20 3.26
query34 15.44 4.01 3.38
query35 3.35 3.34 3.36
query36 0.56 0.44 0.44
query37 0.09 0.06 0.07
query38 0.05 0.04 0.04
query39 0.04 0.03 0.03
query40 0.18 0.16 0.14
query41 0.08 0.03 0.03
query42 0.04 0.03 0.03
query43 0.05 0.03 0.04
Total cold run time: 96.39 s
Total hot run time: 24.62 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org