You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/06/20 22:15:11 UTC

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #987: HDDS-1685. Recon: Add support for 'start' query param to containers…

avijayanhwx commented on a change in pull request #987: HDDS-1685. Recon: Add support for 'start' query param to containers…
URL: https://github.com/apache/hadoop/pull/987#discussion_r296032651
 
 

 ##########
 File path: hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/spi/ContainerDBServiceProvider.java
 ##########
 @@ -85,7 +86,8 @@ Integer getCountForForContainerKeyPrefix(
    * @return Map of containerID -> containerMetadata.
    * @throws IOException
    */
-  Map<Long, ContainerMetadata> getContainers(int limit) throws IOException;
+  Map<Long, ContainerMetadata> getContainers(int limit, long start)
 
 Review comment:
   According to the implementation, the start key will be skipped if present in the seek. This is to support a pagination kind of API. Maybe, we can change the param name to reflect this. Something like previous instead of start?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org