You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Rustem Rafikov (JIRA)" <ji...@apache.org> on 2007/11/14 12:19:43 UTC
[jira] Created: (HARMONY-5122) [classlib][icu] significant
performance degradation atfter ICU related commits
[classlib][icu] significant performance degradation atfter ICU related commits
------------------------------------------------------------------------------
Key: HARMONY-5122
URL: https://issues.apache.org/jira/browse/HARMONY-5122
Project: Harmony
Issue Type: Bug
Components: Classlib
Environment: windows 32, linux 32
Reporter: Rustem Rafikov
Significant performance degradation is observed on SPECjbb2005 after ICU related commits.
There were two such commits:
1. r592434 - "Apply patch Harmony-5061 which removes the duplicate locale data"
2. r593469 - "fix the regression that we have different locale data for Europe/London, along with some fixes for other difference against RI"
The second one causes 15-20% degradation on jbb2005.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5122) [classlib][icu] significant
performance degradation atfter ICU related commits
Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tony Wu resolved HARMONY-5122.
------------------------------
Resolution: Fixed
worked around in r612718.
> [classlib][icu] significant performance degradation atfter ICU related commits
> ------------------------------------------------------------------------------
>
> Key: HARMONY-5122
> URL: https://issues.apache.org/jira/browse/HARMONY-5122
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: windows 32, linux 32
> Reporter: Rustem Rafikov
> Assignee: Tony Wu
> Attachments: testDLT.java
>
>
> Significant performance degradation is observed on SPECjbb2005 after ICU related commits.
> There were two such commits:
> 1. r592434 - "Apply patch Harmony-5061 which removes the duplicate locale data"
> 2. r593469 - "fix the regression that we have different locale data for Europe/London, along with some fixes for other difference against RI"
> The second one causes 15-20% degradation on jbb2005.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5122) [classlib][icu] significant
performance degradation atfter ICU related commits
Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tony Wu reassigned HARMONY-5122:
--------------------------------
Assignee: Tony Wu
> [classlib][icu] significant performance degradation atfter ICU related commits
> ------------------------------------------------------------------------------
>
> Key: HARMONY-5122
> URL: https://issues.apache.org/jira/browse/HARMONY-5122
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: windows 32, linux 32
> Reporter: Rustem Rafikov
> Assignee: Tony Wu
> Attachments: testDLT.java
>
>
> Significant performance degradation is observed on SPECjbb2005 after ICU related commits.
> There were two such commits:
> 1. r592434 - "Apply patch Harmony-5061 which removes the duplicate locale data"
> 2. r593469 - "fix the regression that we have different locale data for Europe/London, along with some fixes for other difference against RI"
> The second one causes 15-20% degradation on jbb2005.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5122) [classlib][icu] significant
performance degradation atfter ICU related commits
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Shipilev updated HARMONY-5122:
--------------------------------------
Attachment: testDLT.java
During the investigation I've found that performance problems on SPECjbb2005 are caused by method SimpleTimeZone.useDaylightTime(). After REVERTING this chunk:
Index: modules/luni/src/main/java/java/util/SimpleTimeZone.java
===================================================================
--- modules/luni/src/main/java/java/util/SimpleTimeZone.java (revision 593468)
+++ modules/luni/src/main/java/java/util/SimpleTimeZone.java (revision 593469)
@@ -837,7 +738,7 @@
*/
@Override
public boolean useDaylightTime() {
- return useDaylight;
+ return icuTZ.useDaylightTime();
}
private static final ObjectStreamField[] serialPersistentFields = {
On the attached microtest running on Windows/ia32 Harmony:
Harmony-r593446
elapsed: 4906
elapsed: 1375
elapsed: 1360
elapsed: 1375
elapsed: 1375
elapsed: 1359
elapsed: 1375
elapsed: 1359
elapsed: 1359
elapsed: 1375
Harmony-r593469 (with guilty commit):
elapsed: 6265
elapsed: 2734
elapsed: 2734
elapsed: 2735
elapsed: 2734
elapsed: 2734
elapsed: 2734
elapsed: 2735
elapsed: 2734
elapsed: 2735
Harmony-r593469 (with guilty commit AND reverted chunk):
elapsed: 4735
elapsed: 1375
elapsed: 1359
elapsed: 1375
elapsed: 1375
elapsed: 1360
elapsed: 1375
elapsed: 1375
elapsed: 1359
elapsed: 1375
> [classlib][icu] significant performance degradation atfter ICU related commits
> ------------------------------------------------------------------------------
>
> Key: HARMONY-5122
> URL: https://issues.apache.org/jira/browse/HARMONY-5122
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: windows 32, linux 32
> Reporter: Rustem Rafikov
> Attachments: testDLT.java
>
>
> Significant performance degradation is observed on SPECjbb2005 after ICU related commits.
> There were two such commits:
> 1. r592434 - "Apply patch Harmony-5061 which removes the duplicate locale data"
> 2. r593469 - "fix the regression that we have different locale data for Europe/London, along with some fixes for other difference against RI"
> The second one causes 15-20% degradation on jbb2005.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5122) [classlib][icu] significant
performance degradation atfter ICU related commits
Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542671 ]
Tony Wu commented on HARMONY-5122:
----------------------------------
I've reported it to icu bug tracker and will follow this issue.
http://bugs.icu-project.org/trac/ticket/6027
> [classlib][icu] significant performance degradation atfter ICU related commits
> ------------------------------------------------------------------------------
>
> Key: HARMONY-5122
> URL: https://issues.apache.org/jira/browse/HARMONY-5122
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: windows 32, linux 32
> Reporter: Rustem Rafikov
> Assignee: Tony Wu
> Attachments: testDLT.java
>
>
> Significant performance degradation is observed on SPECjbb2005 after ICU related commits.
> There were two such commits:
> 1. r592434 - "Apply patch Harmony-5061 which removes the duplicate locale data"
> 2. r593469 - "fix the regression that we have different locale data for Europe/London, along with some fixes for other difference against RI"
> The second one causes 15-20% degradation on jbb2005.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.