You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jayapal Reddy <ja...@citrix.com> on 2013/04/25 12:35:29 UTC
Review Request: updated cloud-early-config to copy iptables-* config files
to rules file to work old templates
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10774/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek, edison su, Chiradeep Vittal, Rohit Yadav, and anthony xu.
Description
-------
Updated the cloud early config also to copy the /etc/iptables/iptables-router (iptables-*) to /etc/iptables/rules.
This addresses bug CLOUDSTACK-2161.
Diffs
-----
patches/systemvm/debian/config/etc/init.d/cloud-early-config 187ae25
Diff: https://reviews.apache.org/r/10774/diff/
Testing
-------
Tested by copying cloud-early-config to router with old template.
Thanks,
Jayapal Reddy
Re: Review Request: updated cloud-early-config to copy iptables-* config
files to rules file to work old templates
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10774/#review19756
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On April 25, 2013, 10:35 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10774/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 10:35 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, edison su, Chiradeep Vittal, Rohit Yadav, and anthony xu.
>
>
> Description
> -------
>
> Updated the cloud early config also to copy the /etc/iptables/iptables-router (iptables-*) to /etc/iptables/rules.
>
>
> This addresses bug CLOUDSTACK-2161.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/etc/init.d/cloud-early-config 187ae25
>
> Diff: https://reviews.apache.org/r/10774/diff/
>
>
> Testing
> -------
>
> Tested by copying cloud-early-config to router with old template.
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: updated cloud-early-config to copy iptables-* config
files to rules file to work old templates
Posted by Jayapal Reddy <ja...@citrix.com>.
> On April 25, 2013, 4:54 p.m., Rohit Yadav wrote:
> > patches/systemvm/debian/config/etc/init.d/cloud-early-config, line 770
> > <https://reviews.apache.org/r/10774/diff/1/?file=284392#file284392line770>
> >
> > Is this file for ipv6? I see a rules.v4?
iptables-router (iptables-*) file is ipv4 rules configuration.
I did not find the ipv6 ip6tables rules configuration file.
When this file is added the owner should update the cloud-early-config to copy the rules file to copy rule.v6
- Jayapal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10774/#review19706
-----------------------------------------------------------
On April 25, 2013, 10:35 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10774/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 10:35 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, edison su, Chiradeep Vittal, Rohit Yadav, and anthony xu.
>
>
> Description
> -------
>
> Updated the cloud early config also to copy the /etc/iptables/iptables-router (iptables-*) to /etc/iptables/rules.
>
>
> This addresses bug CLOUDSTACK-2161.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/etc/init.d/cloud-early-config 187ae25
>
> Diff: https://reviews.apache.org/r/10774/diff/
>
>
> Testing
> -------
>
> Tested by copying cloud-early-config to router with old template.
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: updated cloud-early-config to copy iptables-* config
files to rules file to work old templates
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10774/#review19706
-----------------------------------------------------------
Did not test your patch but saw the diff. Mostly looks good, we'll wait for other reviewers to review, test and ship!
patches/systemvm/debian/config/etc/init.d/cloud-early-config
<https://reviews.apache.org/r/10774/#comment40645>
Remove comment if not needed?
patches/systemvm/debian/config/etc/init.d/cloud-early-config
<https://reviews.apache.org/r/10774/#comment40646>
Is this file for ipv6? I see a rules.v4?
- Rohit Yadav
On April 25, 2013, 10:35 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10774/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 10:35 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, edison su, Chiradeep Vittal, Rohit Yadav, and anthony xu.
>
>
> Description
> -------
>
> Updated the cloud early config also to copy the /etc/iptables/iptables-router (iptables-*) to /etc/iptables/rules.
>
>
> This addresses bug CLOUDSTACK-2161.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/etc/init.d/cloud-early-config 187ae25
>
> Diff: https://reviews.apache.org/r/10774/diff/
>
>
> Testing
> -------
>
> Tested by copying cloud-early-config to router with old template.
>
>
> Thanks,
>
> Jayapal Reddy
>
>