You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/12 07:09:01 UTC

[GitHub] [incubator-shardingsphere] dongzl opened a new pull request #4260: refactor orchestration config for apollo & nacos. 

dongzl opened a new pull request #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260
 
 
   For #3185 .
   
   Changes proposed in this pull request:
   
   fixes orchestration config listener for nacos and apollo.
   refactor orchestration config for apollo.
   fixes nacos config key name.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#discussion_r378214695
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/wrapper/ApolloOpenApiWrapper.java
 ##########
 @@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.orchestration.center.instance.wrapper;
+
+import com.ctrip.framework.apollo.core.ConfigConsts;
+import com.ctrip.framework.apollo.openapi.client.ApolloOpenApiClient;
+import com.ctrip.framework.apollo.openapi.client.constant.ApolloOpenApiConstants;
+import com.ctrip.framework.apollo.openapi.dto.NamespaceReleaseDTO;
+import com.ctrip.framework.apollo.openapi.dto.OpenItemDTO;
+import com.google.common.primitives.Ints;
+import org.apache.shardingsphere.orchestration.center.configuration.InstanceConfiguration;
+
+import java.util.Objects;
+import java.util.Properties;
+
+/**
+ * Apollo open api client wrapper.
+ *
+ * @author dongzonglei
+ */
+public final class ApolloOpenApiWrapper {
+    
+    private ApolloOpenApiClient client;
+    
+    private String namespace;
+    
+    private String appId;
+    
+    private String env;
+    
+    private String clusterName;
+    
+    private String administrator;
+    
+    public ApolloOpenApiWrapper(final InstanceConfiguration config, final Properties properties) {
+        namespace = config.getNamespace();
+        appId = properties.getProperty("appId", "APOLLO_SHARDING_SPHERE");
+        env = properties.getProperty("env", "DEV");
+        clusterName = properties.getProperty("clusterName", ConfigConsts.CLUSTER_NAME_DEFAULT);
+        administrator = properties.getProperty("administrator");
+        String apolloToken = properties.getProperty("token");
+        String portalUrl = properties.getProperty("portalUrl");
+        Integer connectTimeout = Ints.tryParse(Objects.toString(properties.get("connectTimeout")));
+        Integer readTimeout = Ints.tryParse(Objects.toString(properties.get("readTimeout")));
+        client = ApolloOpenApiClient.newBuilder().withPortalUrl(portalUrl)
+                .withConnectTimeout(connectTimeout == null ? ApolloOpenApiConstants.DEFAULT_CONNECT_TIMEOUT : connectTimeout)
+                .withReadTimeout(readTimeout == null ? ApolloOpenApiConstants.DEFAULT_READ_TIMEOUT : readTimeout)
+                .withToken(apolloToken).build();
+    }
+    
+    /**
+     * Get config value by key.
+     * 
+     * @param key key
+     * @return value
+     */
+    public String getValue(final String key) {
+        OpenItemDTO itemDTO = client.getItem(appId, env, clusterName, namespace, key);
+        if (itemDTO == null) {
+            return null;
+        }
+        return itemDTO.getValue();
+    }
+    
+    /**
+     * Persist config.
+     * 
+     * @param key key
+     * @param value value
+     */
+    public void persist(final String key, final String value) {
 
 Review comment:
   fix code, use try catch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] wgy8283335 commented on a change in pull request #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#discussion_r378104418
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/wrapper/ApolloOpenApiWrapper.java
 ##########
 @@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.orchestration.center.instance.wrapper;
+
+import com.ctrip.framework.apollo.core.ConfigConsts;
+import com.ctrip.framework.apollo.openapi.client.ApolloOpenApiClient;
+import com.ctrip.framework.apollo.openapi.client.constant.ApolloOpenApiConstants;
+import com.ctrip.framework.apollo.openapi.dto.NamespaceReleaseDTO;
+import com.ctrip.framework.apollo.openapi.dto.OpenItemDTO;
+import com.google.common.primitives.Ints;
+import org.apache.shardingsphere.orchestration.center.configuration.InstanceConfiguration;
+
+import java.util.Objects;
+import java.util.Properties;
+
+/**
+ * Apollo open api client wrapper.
+ *
+ * @author dongzonglei
+ */
+public final class ApolloOpenApiWrapper {
+    
+    private ApolloOpenApiClient client;
+    
+    private String namespace;
+    
+    private String appId;
+    
+    private String env;
+    
+    private String clusterName;
+    
+    private String administrator;
+    
+    public ApolloOpenApiWrapper(final InstanceConfiguration config, final Properties properties) {
+        namespace = config.getNamespace();
+        appId = properties.getProperty("appId", "APOLLO_SHARDING_SPHERE");
+        env = properties.getProperty("env", "DEV");
+        clusterName = properties.getProperty("clusterName", ConfigConsts.CLUSTER_NAME_DEFAULT);
+        administrator = properties.getProperty("administrator");
+        String apolloToken = properties.getProperty("token");
+        String portalUrl = properties.getProperty("portalUrl");
+        Integer connectTimeout = Ints.tryParse(Objects.toString(properties.get("connectTimeout")));
+        Integer readTimeout = Ints.tryParse(Objects.toString(properties.get("readTimeout")));
+        client = ApolloOpenApiClient.newBuilder().withPortalUrl(portalUrl)
+                .withConnectTimeout(connectTimeout == null ? ApolloOpenApiConstants.DEFAULT_CONNECT_TIMEOUT : connectTimeout)
+                .withReadTimeout(readTimeout == null ? ApolloOpenApiConstants.DEFAULT_READ_TIMEOUT : readTimeout)
+                .withToken(apolloToken).build();
+    }
+    
+    /**
+     * Get config value by key.
+     * 
+     * @param key key
+     * @return value
+     */
+    public String getValue(final String key) {
+        OpenItemDTO itemDTO = client.getItem(appId, env, clusterName, namespace, key);
+        if (itemDTO == null) {
+            return null;
+        }
+        return itemDTO.getValue();
+    }
+    
+    /**
+     * Persist config.
+     * 
+     * @param key key
+     * @param value value
+     */
+    public void persist(final String key, final String value) {
 
 Review comment:
   Whether we should add TCC code for transaction.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#discussion_r378095166
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/node/ConfigurationNode.java
 ##########
 @@ -57,6 +60,16 @@ public String getSchemaPath() {
         return Joiner.on("/").join("", name, ROOT, SCHEMA_NODE);
     }
     
+    /**
+     * Get schema name path.
+     * 
+     * @param schemaName schema name
+     * @return schema name path
+     */
+    public String getSchemaNamePath(final String schemaName) {
+        return Joiner.on("/").join("", name, ROOT, SCHEMA_NODE, schemaName);
 
 Review comment:
   constant instead of literal？

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl merged pull request #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
dongzl merged pull request #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#discussion_r378095736
 
 

 ##########
 File path: sharding-proxy/sharding-proxy-bootstrap/src/main/resources/conf/server.yaml
 ##########
 @@ -29,11 +29,6 @@
 #    namespace: orchestration
 #    props:
 #      overwrite: false
-#      retry-interval-milliseconds: 10
-#      time-to-live-seconds: 10
-#      max-retries: 10
-#      operation-timeout-milliseconds: 10
-#      digest: 123
 #
 
 Review comment:
   If we didn't remove these parameters from config file, I suggest keep them here for examples.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#issuecomment-585077745
 
 
   ## Pull Request Test Coverage Report for [Build 9471](https://coveralls.io/builds/28678357)
   
   * **45** of **97**   **(46.39%)**  changed or added relevant lines in **8** files are covered.
   * **98** unchanged lines in **10** files lost coverage.
   * Overall coverage decreased (**-0.1%**) to **64.731%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-api/src/main/java/org/apache/shardingsphere/orchestration/center/util/ConfigKeyUtils.java](https://coveralls.io/builds/28678357/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Futil%2FConfigKeyUtils.java#L25) | 3 | 4 | 75.0%
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/node/ConfigurationNode.java](https://coveralls.io/builds/28678357/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Fnode%2FConfigurationNode.java#L143) | 5 | 6 | 83.33%
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28678357/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L60) | 13 | 18 | 72.22%
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java](https://coveralls.io/builds/28678357/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FSchemaChangedListener.java#L81) | 1 | 10 | 10.0%
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/wrapper/ApolloOpenApiWrapper.java](https://coveralls.io/builds/28678357/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2Fwrapper%2FApolloOpenApiWrapper.java#L50) | 0 | 36 | 0.0%
   <!-- | **Total:** | **45** | **97** | **46.39%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/DescribeStatement.java](https://coveralls.io/builds/28678357/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FDescribeStatement.java#L33) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowColumnsStatement.java](https://coveralls.io/builds/28678357/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowColumnsStatement.java#L33) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowCreateTableStatement.java](https://coveralls.io/builds/28678357/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowCreateTableStatement.java#L33) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28678357/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-relation/src/main/java/org/apache/shardingsphere/sql/parser/relation/segment/table/TablesContext.java](https://coveralls.io/builds/28678357/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-relation%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Frelation%2Fsegment%2Ftable%2FTablesContext.java#L82) | 1 | 98.46% |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28678357/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L62) | 2 | 65.63% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/ddl/AlterTableStatement.java](https://coveralls.io/builds/28678357/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fddl%2FAlterTableStatement.java#L36) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/ddl/CreateTableStatement.java](https://coveralls.io/builds/28678357/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fddl%2FCreateTableStatement.java#L36) | 2 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28678357/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDDLVisitor.java](https://coveralls.io/builds/28678357/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDDLVisitor.java#L83) | 84 | 0% |
   <!-- | **Total:** | **98** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28678357/badge)](https://coveralls.io/builds/28678357) |
   | :-- | --: |
   | Change from base [Build 827](https://coveralls.io/builds/28677479): |  -0.1% |
   | Covered Lines: | 11005 |
   | Relevant Lines: | 17001 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#issuecomment-585077745
 
 
   ## Pull Request Test Coverage Report for [Build 9486](https://coveralls.io/builds/28685094)
   
   * **48** of **103**   **(46.6%)**  changed or added relevant lines in **8** files are covered.
   * **100** unchanged lines in **11** files lost coverage.
   * Overall coverage decreased (**-0.1%**) to **64.73%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-api/src/main/java/org/apache/shardingsphere/orchestration/center/util/ConfigKeyUtils.java](https://coveralls.io/builds/28685094/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Futil%2FConfigKeyUtils.java#L25) | 3 | 4 | 75.0%
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/node/ConfigurationNode.java](https://coveralls.io/builds/28685094/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Fnode%2FConfigurationNode.java#L147) | 8 | 9 | 88.89%
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28685094/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L62) | 13 | 21 | 61.9%
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java](https://coveralls.io/builds/28685094/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FSchemaChangedListener.java#L81) | 1 | 10 | 10.0%
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/wrapper/ApolloOpenApiWrapper.java](https://coveralls.io/builds/28685094/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2Fwrapper%2FApolloOpenApiWrapper.java#L50) | 0 | 36 | 0.0%
   <!-- | **Total:** | **48** | **103** | **46.6%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/DescribeStatement.java](https://coveralls.io/builds/28685094/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FDescribeStatement.java#L33) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowColumnsStatement.java](https://coveralls.io/builds/28685094/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowColumnsStatement.java#L33) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowCreateTableStatement.java](https://coveralls.io/builds/28685094/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowCreateTableStatement.java#L33) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28685094/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-relation/src/main/java/org/apache/shardingsphere/sql/parser/relation/segment/table/TablesContext.java](https://coveralls.io/builds/28685094/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-relation%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Frelation%2Fsegment%2Ftable%2FTablesContext.java#L82) | 1 | 98.46% |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28685094/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L64) | 2 | 61.11% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/ddl/AlterTableStatement.java](https://coveralls.io/builds/28685094/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fddl%2FAlterTableStatement.java#L36) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/ddl/CreateTableStatement.java](https://coveralls.io/builds/28685094/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fddl%2FCreateTableStatement.java#L36) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28685094/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L182) | 2 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28685094/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
   <!-- | **Total:** | **100** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28685094/badge)](https://coveralls.io/builds/28685094) |
   | :-- | --: |
   | Change from base [Build 827](https://coveralls.io/builds/28677479): |  -0.1% |
   | Covered Lines: | 11006 |
   | Relevant Lines: | 17003 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#discussion_r378214530
 
 

 ##########
 File path: sharding-proxy/sharding-proxy-bootstrap/src/main/resources/conf/server.yaml
 ##########
 @@ -29,11 +29,6 @@
 #    namespace: orchestration
 #    props:
 #      overwrite: false
-#      retry-interval-milliseconds: 10
-#      time-to-live-seconds: 10
-#      max-retries: 10
-#      operation-timeout-milliseconds: 10
-#      digest: 123
 #
 
 Review comment:
   I have reverted the config.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#issuecomment-585077745
 
 
   ## Pull Request Test Coverage Report for [Build 1691](https://coveralls.io/builds/28678174)
   
   * **45** of **97**   **(46.39%)**  changed or added relevant lines in **8** files are covered.
   * **2** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.08%**) to **64.757%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-api/src/main/java/org/apache/shardingsphere/orchestration/center/util/ConfigKeyUtils.java](https://coveralls.io/builds/28678174/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Futil%2FConfigKeyUtils.java#L25) | 3 | 4 | 75.0%
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/node/ConfigurationNode.java](https://coveralls.io/builds/28678174/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Fnode%2FConfigurationNode.java#L143) | 5 | 6 | 83.33%
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28678174/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L60) | 13 | 18 | 72.22%
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java](https://coveralls.io/builds/28678174/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FSchemaChangedListener.java#L81) | 1 | 10 | 10.0%
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/wrapper/ApolloOpenApiWrapper.java](https://coveralls.io/builds/28678174/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2Fwrapper%2FApolloOpenApiWrapper.java#L50) | 0 | 36 | 0.0%
   <!-- | **Total:** | **45** | **97** | **46.39%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28678174/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L62) | 2 | 65.63% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28678174/badge)](https://coveralls.io/builds/28678174) |
   | :-- | --: |
   | Change from base [Build 827](https://coveralls.io/builds/28677479): |  -0.08% |
   | Covered Lines: | 10997 |
   | Relevant Lines: | 16982 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#discussion_r378214271
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/node/ConfigurationNode.java
 ##########
 @@ -57,6 +60,16 @@ public String getSchemaPath() {
         return Joiner.on("/").join("", name, ROOT, SCHEMA_NODE);
     }
     
+    /**
+     * Get schema name path.
+     * 
+     * @param schemaName schema name
+     * @return schema name path
+     */
+    public String getSchemaNamePath(final String schemaName) {
+        return Joiner.on("/").join("", name, ROOT, SCHEMA_NODE, schemaName);
 
 Review comment:
   fix code, use class constant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#discussion_r378095253
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/node/ConfigurationNode.java
 ##########
 @@ -119,6 +132,19 @@ public String getSchemaName(final String configurationNodeFullPath) {
         return result;
     }
     
+    /**
+     * Split sharding schema name.
+     * 
+     * @param shardingSchemaNames sharding schema names
+     * @return sharding schema names
+     */
+    public Collection<String> splitShardingSchemaName(final String shardingSchemaNames) {
+        if (Strings.isNullOrEmpty(shardingSchemaNames)) {
+            return Collections.emptyList();
+        }
+        return Splitter.on(",").splitToList(shardingSchemaNames);
 
 Review comment:
   constant？

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on issue #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#issuecomment-585150564
 
 
   > Does test coverage must be satisfied?
   
   Haoran Meng is following to make more UT cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#issuecomment-585077745
 
 
   ## Pull Request Test Coverage Report for [Build 1699](https://coveralls.io/builds/28683750)
   
   * **48** of **103**   **(46.6%)**  changed or added relevant lines in **8** files are covered.
   * **97** unchanged lines in **10** files lost coverage.
   * Overall coverage decreased (**-0.09%**) to **64.742%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-api/src/main/java/org/apache/shardingsphere/orchestration/center/util/ConfigKeyUtils.java](https://coveralls.io/builds/28683750/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Futil%2FConfigKeyUtils.java#L25) | 3 | 4 | 75.0%
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/node/ConfigurationNode.java](https://coveralls.io/builds/28683750/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Fnode%2FConfigurationNode.java#L147) | 8 | 9 | 88.89%
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28683750/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L62) | 13 | 21 | 61.9%
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java](https://coveralls.io/builds/28683750/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FSchemaChangedListener.java#L81) | 1 | 10 | 10.0%
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/wrapper/ApolloOpenApiWrapper.java](https://coveralls.io/builds/28683750/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2Fwrapper%2FApolloOpenApiWrapper.java#L50) | 0 | 36 | 0.0%
   <!-- | **Total:** | **48** | **103** | **46.6%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/DescribeStatement.java](https://coveralls.io/builds/28683750/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FDescribeStatement.java#L33) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowColumnsStatement.java](https://coveralls.io/builds/28683750/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowColumnsStatement.java#L33) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowCreateTableStatement.java](https://coveralls.io/builds/28683750/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowCreateTableStatement.java#L33) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28683750/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-relation/src/main/java/org/apache/shardingsphere/sql/parser/relation/segment/table/TablesContext.java](https://coveralls.io/builds/28683750/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-relation%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Frelation%2Fsegment%2Ftable%2FTablesContext.java#L82) | 1 | 98.46% |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28683750/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L64) | 2 | 63.89% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/ddl/AlterTableStatement.java](https://coveralls.io/builds/28683750/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fddl%2FAlterTableStatement.java#L36) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/ddl/CreateTableStatement.java](https://coveralls.io/builds/28683750/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fddl%2FCreateTableStatement.java#L36) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28683750/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L182) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDDLVisitor.java](https://coveralls.io/builds/28683750/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDDLVisitor.java#L83) | 84 | 0% |
   <!-- | **Total:** | **97** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28683750/badge)](https://coveralls.io/builds/28683750) |
   | :-- | --: |
   | Change from base [Build 827](https://coveralls.io/builds/28677479): |  -0.09% |
   | Covered Lines: | 11008 |
   | Relevant Lines: | 17003 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#discussion_r378214358
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/node/ConfigurationNode.java
 ##########
 @@ -119,6 +132,19 @@ public String getSchemaName(final String configurationNodeFullPath) {
         return result;
     }
     
+    /**
+     * Split sharding schema name.
+     * 
+     * @param shardingSchemaNames sharding schema names
+     * @return sharding schema names
+     */
+    public Collection<String> splitShardingSchemaName(final String shardingSchemaNames) {
+        if (Strings.isNullOrEmpty(shardingSchemaNames)) {
+            return Collections.emptyList();
+        }
+        return Splitter.on(",").splitToList(shardingSchemaNames);
 
 Review comment:
   the same to above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4260: refactor orchestration config for apollo & nacos.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#issuecomment-585209250
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@e03143c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `60.8%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #4260   +/-   ##
   =========================================
     Coverage          ?   60.81%           
     Complexity        ?      352           
   =========================================
     Files             ?     1013           
     Lines             ?    17003           
     Branches          ?     3010           
   =========================================
     Hits              ?    10341           
     Misses            ?     6007           
     Partials          ?      655
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...core/strategy/route/none/NoneShardingStrategy.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9yb3V0ZS9ub25lL05vbmVTaGFyZGluZ1N0cmF0ZWd5LmphdmE=) | `100% <ø> (ø)` | `0 <0> (?)` | |
   | [.../masterslave/LoadBalanceStrategyConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYXBpL2NvbmZpZy9tYXN0ZXJzbGF2ZS9Mb2FkQmFsYW5jZVN0cmF0ZWd5Q29uZmlndXJhdGlvbi5qYXZh) | `50% <ø> (ø)` | `1 <0> (?)` | |
   | [...route/time/exception/TimeServiceInitException.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9kYXRhYmFzZS10aW1lLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JvdXRlL3RpbWUvZXhjZXB0aW9uL1RpbWVTZXJ2aWNlSW5pdEV4Y2VwdGlvbi5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...config/common/YamlAuthenticationConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9jb21tb24vWWFtbEF1dGhlbnRpY2F0aW9uQ29uZmlndXJhdGlvbi5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | |
   | [...ig/sharding/YamlShardingStrategyConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9zaGFyZGluZy9ZYW1sU2hhcmRpbmdTdHJhdGVneUNvbmZpZ3VyYXRpb24uamF2YQ==) | `100% <ø> (ø)` | `1 <0> (?)` | |
   | [...core/strategy/route/hint/HintShardingStrategy.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9yb3V0ZS9oaW50L0hpbnRTaGFyZGluZ1N0cmF0ZWd5LmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...config/sharding/YamlKeyGeneratorConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9zaGFyZGluZy9ZYW1sS2V5R2VuZXJhdG9yQ29uZmlndXJhdGlvbi5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | |
   | [...config/sharding/YamlShardingRuleConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9zaGFyZGluZy9ZYW1sU2hhcmRpbmdSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | |
   | [.../yaml/config/common/YamlRootRuleConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9jb21tb24vWWFtbFJvb3RSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | |
   | [...ml/config/sharding/YamlTableRuleConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL2NvbmZpZy9zaGFyZGluZy9ZYW1sVGFibGVSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `100% <ø> (ø)` | `1 <0> (?)` | |
   | ... and [121 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260?src=pr&el=footer). Last update [e03143c...4a426f9](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4260?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services