You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/12/01 13:31:37 UTC
[GitHub] [ozone] captainzmc opened a new pull request, #4024: HDDS-7574. Not generate dependency-reduced-pom.xml by default
captainzmc opened a new pull request, #4024:
URL: https://github.com/apache/ozone/pull/4024
## What changes were proposed in this pull request?
During the release of 1.3.0, we found two more files in two directories under ozone-1.3.0-src.tar.gz:
ozone-1.3.0-src/hadoop-ozone/ozonefs-hadoop3-client: dependency-reduced-pom.xml
ozone-1.3.0-src/hadoop-ozone/ozonefs-shaded: dependency-reduced-pom.xml
And the reason is that：
maven-shade-plugin generates dependency-reduced-pom.xml by default. If it is not needed we need to turn it off.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7574
## How was this patch tested?
Can use the following command to generate ozone-1.3.0-src.tar.gz and check if the two directories above if contain dependency-reduced-pom.xml.
mvn clean install -Dmaven.javadoc.skip=true -DskipTests -Psign,dist,src -Dtar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] captainzmc commented on pull request #4024: HDDS-7574. Not generate dependency-reduced-pom.xml by default
Posted by GitBox <gi...@apache.org>.
captainzmc commented on PR #4024:
URL: https://github.com/apache/ozone/pull/4024#issuecomment-1334854138
Let's close this PR. Thanks @adoroszlai for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4024: HDDS-7574. Not generate dependency-reduced-pom.xml by default
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #4024:
URL: https://github.com/apache/ozone/pull/4024#issuecomment-1333878416
Thanks @captainzmc for working on this.
* I have found that `dependency-reduced-pom.xml` is also present in previous releases (checked 1.0.0, 1.1.0, 1.2.1), so this is not a blocker in any case.
* I think the file should still be generated, as it may be useful for projects that depend on the shaded FS jars. The problem is that it is an artifact of the build, does not belong to the sources.
* The root cause is probably that the same `mvn` run is used for generating both binary and source tarballs. We should exclude it from the source tarball explicitly to allow the combined run. Alternatively, we may be able to build the source tarball first, then the binary one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] captainzmc closed pull request #4024: HDDS-7574. Not generate dependency-reduced-pom.xml by default
Posted by GitBox <gi...@apache.org>.
captainzmc closed pull request #4024: HDDS-7574. Not generate dependency-reduced-pom.xml by default
URL: https://github.com/apache/ozone/pull/4024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] captainzmc commented on pull request #4024: HDDS-7574. Not generate dependency-reduced-pom.xml by default
Posted by GitBox <gi...@apache.org>.
captainzmc commented on PR #4024:
URL: https://github.com/apache/ozone/pull/4024#issuecomment-1333966633
Thanks for @adoroszlai's suggestion. If these files really have no impact, I agree to keep the status quo.
> The root cause is probably that the same mvn run is used for generating both binary and source tarballs. We should exclude it from the source tarball explicitly to allow the combined run. Alternatively, we may be able to build the source tarball first, then the binary one.
Strangely, I try to generate only the source tarball with the following command. Found that dependency-reduced-pom.xml still exists. So it's probably not the binary tarball that's causing this problem.
mvn clean install -Dmaven.javadoc.skip=true -DskipTests -Psign,src -Dgpg.keyname="$CODESIGNINGKEY"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org