You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/07/11 00:18:38 UTC
Re: Review Request 60345: Windows: Set Unicode compilation flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60345/#review180138
-----------------------------------------------------------
Ship it!
- Joseph Wu
On June 21, 2017, 3:17 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60345/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 3:17 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
>
>
> Bugs: MESOS-6817
> https://issues.apache.org/jira/browse/MESOS-6817
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Set Unicode compilation flags.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 3fa2e2f3b51a7a8dfe05085298f240019ff7b9c4
>
>
> Diff: https://reviews.apache.org/r/60345/diff/1/
>
>
> Testing
> -------
>
> # Windows
>
> This is with Visual Studio 2017 tools, _without_ the long path registry key set.
>
> ## `stout-tests`
> ```
> [----------] Global test environment tear-down
> [==========] 253 tests from 42 test cases ran. (4910 ms total)
> [ PASSED ] 253 tests.
>
> YOU HAVE 12 DISABLED TESTS
> ```
>
> ## `libprocess-tests`
> ```
> [----------] Global test environment tear-down
> [==========] 148 tests from 27 test cases ran. (1232 ms total)
> [ PASSED ] 148 tests.
>
> YOU HAVE 15 DISABLED TESTS
> ```
>
> ## `mesos-tests`
> ```
> [----------] Global test environment tear-down
> [==========] 596 tests from 61 test cases ran. (115278 ms total)
> [ PASSED ] 596 tests.
>
> YOU HAVE 166 DISABLED TESTS
> ```
>
> # Linux
>
> This is using `make check` on CentOS 7.
>
> ## `stout-tests`
> ```
> [----------] Global test environment tear-down
> [==========] 310 tests from 50 test cases ran. (392 ms total)
> [ PASSED ] 310 tests.
> ```
>
> ## `libprocess-tests`
> ```
> [----------] Global test environment tear-down
> [==========] 193 tests from 33 test cases ran. (960 ms total)
> [ PASSED ] 193 tests.
>
> YOU HAVE 2 DISABLED TESTS
> ```
>
> ## `mesos-tests`
> ```
> [----------] Global test environment tear-down
> [==========] 1611 tests from 177 test cases ran. (481344 ms total)
> [ PASSED ] 1611 tests.
>
> YOU HAVE 20 DISABLED TESTS
> ```
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>