You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2019/12/13 22:25:24 UTC

[GitHub] [libcloud] Kami commented on a change in pull request #1386: Support disk_size parameter for create_node

Kami commented on a change in pull request #1386: Support disk_size parameter for create_node
URL: https://github.com/apache/libcloud/pull/1386#discussion_r357856692
 
 

 ##########
 File path: libcloud/compute/drivers/gce.py
 ##########
 @@ -4201,7 +4205,7 @@ def create_node(
             ex_can_ip_forward, ex_disks_gce_struct, ex_nic_gce_struct,
             ex_on_host_maintenance, ex_automatic_restart, ex_preemptible,
             ex_subnetwork, ex_labels, ex_accelerator_type,
-            ex_accelerator_count)
 
 Review comment:
   To avoid potential bugs it would probably be safer to use keyword instead of positional argumentshere  in the future, but this also works for now since other arguments are already positional.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services