You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/08/28 16:54:48 UTC
Review Request 68542: De-duplicated identical read-only requests to
master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68542/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
Under certain assumptions, we can safely assume that
two requests with the same parametesr to the same endpoint
will return the same result. This is most noticeable for
the `/state` endpoint.
In this case, we only need to compute the response once.
Diffs
-----
src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc
src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005
Diff: https://reviews.apache.org/r/68542/diff/1/
Testing
-------
Accessed `localhost:5050/state` on master including these changes.
Thanks,
Benno Evers
Re: Review Request 68542: De-duplicated identical read-only requests
to master.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68542/#review208052
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 68542`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2251/mesos-review-68542
Relevant logs:
- [apply-review-68542.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2251/mesos-review-68542/logs/apply-review-68542.log):
```
error: patch failed: src/master/http.cpp:2383
error: src/master/http.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Aug. 28, 2018, 4:54 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68542/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2018, 4:54 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Under certain assumptions, we can safely assume that
> two requests with the same parametesr to the same endpoint
> will return the same result. This is most noticeable for
> the `/state` endpoint.
>
> In this case, we only need to compute the response once.
>
>
> Diffs
> -----
>
> src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc
> src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005
>
>
> Diff: https://reviews.apache.org/r/68542/diff/1/
>
>
> Testing
> -------
>
> Accessed `localhost:5050/state` on master including these changes.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68542: De-duplicated identical read-only requests
to master.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68542/#review208074
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68542]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 28, 2018, 4:54 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68542/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2018, 4:54 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Under certain assumptions, we can safely assume that
> two requests with the same parametesr to the same endpoint
> will return the same result. This is most noticeable for
> the `/state` endpoint.
>
> In this case, we only need to compute the response once.
>
>
> Diffs
> -----
>
> src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc
> src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005
>
>
> Diff: https://reviews.apache.org/r/68542/diff/1/
>
>
> Testing
> -------
>
> Accessed `localhost:5050/state` on master including these changes.
>
>
> Thanks,
>
> Benno Evers
>
>