You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Michi Mutsuzaki (JIRA)" <ji...@apache.org> on 2012/06/20 22:48:45 UTC
[jira] [Created] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
Michi Mutsuzaki created ZOOKEEPER-1493:
------------------------------------------
Summary: C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
Key: ZOOKEEPER-1493
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
Project: ZooKeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.3.5, 3.4.3
Reporter: Michi Mutsuzaki
Fix For: 3.3.6, 3.4.4, 3.5.0
In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
Posted by "Jacky007 (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501829#comment-13501829 ]
Jacky007 commented on ZOOKEEPER-1493:
-------------------------------------
a memory leak for missing free_buffer(bptr)
> C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1493_3_3.patch, ZOOKEEPER-1493_3_4.patch, ZOOKEEPER-1493.patch
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424519#comment-13424519 ]
Hudson commented on ZOOKEEPER-1493:
-----------------------------------
Integrated in ZooKeeper-trunk #1628 (See [https://builds.apache.org/job/ZooKeeper-trunk/1628/])
ZOOKEEPER-1493. C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called (Michi Mutsuzaki via phunt and mahadev) (Revision 1366784)
Result = SUCCESS
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366784
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/c/src/zookeeper.c
> C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1493.patch, ZOOKEEPER-1493_3_3.patch, ZOOKEEPER-1493_3_4.patch
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417246#comment-13417246 ]
Mahadev konar commented on ZOOKEEPER-1493:
------------------------------------------
Sure. I looked at the patch it looks fine to me. +1 for committing.
> C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1493.patch, ZOOKEEPER-1493_3_3.patch, ZOOKEEPER-1493_3_4.patch
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michi Mutsuzaki updated ZOOKEEPER-1493:
---------------------------------------
Attachment: ZOOKEEPER-1493_3_4.patch
ZOOKEEPER-1493_3_3.patch
> C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1493.patch, ZOOKEEPER-1493_3_3.patch, ZOOKEEPER-1493_3_4.patch
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404658#comment-13404658 ]
Hadoop QA commented on ZOOKEEPER-1493:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12534135/ZOOKEEPER-1493_3_4.patch
against trunk revision 1355657.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1118//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1118//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1118//console
This message is automatically generated.
> C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1493.patch, ZOOKEEPER-1493_3_3.patch, ZOOKEEPER-1493_3_4.patch
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
Posted by "Jacky007 (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501129#comment-13501129 ]
Jacky007 commented on ZOOKEEPER-1493:
-------------------------------------
this patch also solve a potential hang int zookeeper_close() :-)
> C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1493_3_3.patch, ZOOKEEPER-1493_3_4.patch, ZOOKEEPER-1493.patch
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416645#comment-13416645 ]
Michi Mutsuzaki commented on ZOOKEEPER-1493:
--------------------------------------------
It would be difficult to unit test this without refactoring the code. I did run manual tests to verify the patch fixed the issue, though.
--Michi
> C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1493.patch, ZOOKEEPER-1493_3_3.patch, ZOOKEEPER-1493_3_4.patch
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michi Mutsuzaki reassigned ZOOKEEPER-1493:
------------------------------------------
Assignee: Michi Mutsuzaki
> C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404133#comment-13404133 ]
Mahadev konar commented on ZOOKEEPER-1493:
------------------------------------------
Again the patch looks good but we'll need a patch for branch 3.3 and 3.4.
> C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1493.patch
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416634#comment-13416634 ]
Patrick Hunt commented on ZOOKEEPER-1493:
-----------------------------------------
Michi would it be possible to test this change?
> C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1493.patch, ZOOKEEPER-1493_3_3.patch, ZOOKEEPER-1493_3_4.patch
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404653#comment-13404653 ]
Michi Mutsuzaki commented on ZOOKEEPER-1493:
--------------------------------------------
Hi Mahadev,
Here are the patches for 3.3, 3.4, and trunk:
branch-3.3: https://issues.apache.org/jira/secure/attachment/12534134/ZOOKEEPER-1493_3_3.patch
branch-3.4: https://issues.apache.org/jira/secure/attachment/12534135/ZOOKEEPER-1493_3_4.patch
trunk: https://issues.apache.org/jira/secure/attachment/12532779/ZOOKEEPER-1493.patch
I'll update patches for ZOOKEEPER-1494 once these patches are checked in.
Thanks!
--Michi
> C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1493.patch, ZOOKEEPER-1493_3_3.patch, ZOOKEEPER-1493_3_4.patch
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michi Mutsuzaki updated ZOOKEEPER-1493:
---------------------------------------
Attachment: ZOOKEEPER-1493.patch
> C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1493.patch
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1493) C Client: zookeeper_process
doesn't invoke completion callback if zookeeper_close has been called
Posted by "Jacky007 (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501128#comment-13501128 ]
Jacky007 commented on ZOOKEEPER-1493:
-------------------------------------
this patch also solve a potential hang int zookeeper_close() :-)
> C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called
> -------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1493
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1493
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.3, 3.3.5
> Reporter: Michi Mutsuzaki
> Assignee: Michi Mutsuzaki
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1493_3_3.patch, ZOOKEEPER-1493_3_4.patch, ZOOKEEPER-1493.patch
>
>
> In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira