[jira] [Commented] (STORM-2503) lgtm.com alerts: bugs in equality and comparison operations

["Robert Joseph Evans (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019851#comment-16019851 ] 

Robert Joseph Evans commented on STORM-2503:
--------------------------------------------

[~adityasharad],

I merged your pull request into master.  If you want this to go into 1.x please put a pull request up for it.  If you don't have time to do the port please let me know and I would be happy to take that over for you.

Thanks for you work on this.

> lgtm.com alerts: bugs in equality and comparison operations
> -----------------------------------------------------------
>
>                 Key: STORM-2503
>                 URL: https://issues.apache.org/jira/browse/STORM-2503
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Aditya Sharad
>            Assignee: Aditya Sharad
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> There are a number of alerts found by lgtm.com at https://lgtm.com/projects/g/apache/storm/alerts/ that indicate genuine bugs in comparison operations in the Storm code.
> These rules include:
> * Equals on incomparable types (leading to bugs in comparison or caching)
> * Hashed value without hashCode definition
> * Inconsistent equals and hashCode (together with the previous one, this indicates some missing {{hashCode}} implementations)
> * Comparison of identical values (indicating incorrect comparator logic in {{DefaultResourceAwareStrategy}})
> * Useless comparison test (indicating a variable name typo)
> * Suspicious reference equality test of boxed types (indicating a spurious use of {{==}} instead of {{equals}} on boxed types)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)