[GitHub] [iceberg] chenjunjiedada commented on a diff in pull request #6002: Core: Add file seq number to ManifestEntry

[GitBox <gi...@apache.org>]

chenjunjiedada commented on code in PR #6002:
URL: https://github.com/apache/iceberg/pull/6002#discussion_r997932907


##########
core/src/main/java/org/apache/iceberg/InheritableMetadataFactory.java:
##########
@@ -75,6 +75,13 @@ public <F extends ContentFile<F>> ManifestEntry<F> apply(ManifestEntry<F> manife
         manifestEntry.setSequenceNumber(sequenceNumber);
       }
 
+      // in v1 tables, the file sequence number is not persisted and can be safely defaulted to 0
+      // in v2 tables, the file sequence number should be inherited iff the entry status is ADDED

Review Comment:
   typo: iff -> if? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org