[GitHub] [iceberg] kbendick commented on pull request #4878: API: Avoid unnecessary boxing in SnapshotRef equality check by comparing snapshotID via ==

[GitBox <gi...@apache.org>]

kbendick commented on PR #4878:
URL: https://github.com/apache/iceberg/pull/4878#issuecomment-1139763462

   Thanks @amogh-jahagirdar and @jackye1995! If we find other places then we can update them later. Not a high priority issue.
   
   I think there's some code in `MetadataUpdate` that uses `SnapshotRef`, but also with a `name` field and that's where it's copied (it came to me in the night). So I'll check and update it if so.
   
   More then the performance gains, I think the use of primitives and treating them as such signifies something to the reader (especially given we don't tend to use `Optional`).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org