You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tephra.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/01 19:07:00 UTC
[jira] [Commented] (TEPHRA-266) Identify log messages when multiple
instances of Tephra run on a single HBase cluster
[ https://issues.apache.org/jira/browse/TEPHRA-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460028#comment-16460028 ]
ASF GitHub Bot commented on TEPHRA-266:
---------------------------------------
Github user anew commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/74#discussion_r185305932
--- Diff: tephra-core/src/main/java/org/apache/tephra/coprocessor/TransactionStateCache.java ---
@@ -184,4 +185,14 @@ private void refreshState() throws IOException {
public TransactionVisibilityState getLatestState() {
return latestState;
}
+
+ protected void setId(@Nullable String id) {
+ if (id != null) {
+ this.logPrefix = "[" + id + "] ";
+ }
+ }
+
+ private String prefixLog(String message) {
--- End diff --
I was not aware of that. I think this is not logged very frequently, so it's ok.
> Identify log messages when multiple instances of Tephra run on a single HBase cluster
> -------------------------------------------------------------------------------------
>
> Key: TEPHRA-266
> URL: https://issues.apache.org/jira/browse/TEPHRA-266
> Project: Tephra
> Issue Type: Improvement
> Environment:
> Reporter: Poorna Chandra
> Assignee: Poorna Chandra
> Priority: Major
> Fix For: 0.14.0-incubating
>
>
> When multiple instances of Tehpra are run in a single HBase cluster, the log messages from the co-processors of all instances (which are identical except for the timestamp) go into a single region server log file. It becomes very difficult to figure out issues of an instance due to this.
> it would be good if instance id is logged along with the co-processor log messages so that we can identity which messages belong to which instance of Tephra.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)