You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/29 01:00:22 UTC
[jira] [Commented] (BEAM-1402) Make TextIO and AvroIO use
best-practice types.
[ https://issues.apache.org/jira/browse/BEAM-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989668#comment-15989668 ]
ASF GitHub Bot commented on BEAM-1402:
--------------------------------------
GitHub user jkff opened a pull request:
https://github.com/apache/beam/pull/2774
[BEAM-1402] Makes TextIO comply with PTransform style guide
Migration guide: TextIO.Read.from() -> TextIO.read().from; TextIO.Write.to() -> TextIO.write().to()
Also converts both to AutoValue and moves some utility classes to upper level to declutter TextIO.java.
Each individual commit should be trivial to review.
R: @reuvenlax
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam text-style
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2774.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2774
----
commit 2421f80eb46525d18ffa4af1dd0dc398db278b61
Author: Eugene Kirpichov <ki...@google.com>
Date: 2017-04-29T00:14:29Z
Removes leftover no-op withoutValidation methods
commit 98526274d69ed4665f34108b46e678ecf850b561
Author: Eugene Kirpichov <ki...@google.com>
Date: 2017-04-29T00:06:46Z
Removes TextIO.Read.Bound
commit cb18481b034f1b47f47e6f749b73c4395cb9684d
Author: Eugene Kirpichov <ki...@google.com>
Date: 2017-04-29T00:16:14Z
Converts TextIO.Read to AutoValue
commit ed28a1e8a3eca34ddc278b2facbef61cf3dd37f5
Author: Eugene Kirpichov <ki...@google.com>
Date: 2017-04-29T00:28:06Z
Removes TextIO.Write.Bound
commit 51208cd05f0cbf43776772092909da2afaafb1d8
Author: Eugene Kirpichov <ki...@google.com>
Date: 2017-04-29T00:39:01Z
Converts TextIO.Write to AutoValue
commit e5eb565522885b7dae78d45db0cdd4a447cfb14f
Author: Eugene Kirpichov <ki...@google.com>
Date: 2017-04-29T00:46:44Z
Moves TextSource and TextSink to top level
----
> Make TextIO and AvroIO use best-practice types.
> -----------------------------------------------
>
> Key: BEAM-1402
> URL: https://issues.apache.org/jira/browse/BEAM-1402
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Labels: backward-incompatible, starter
> Fix For: First stable release
>
>
> Replace static Read/Write classes with type-instantiated classes.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)