You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2016/05/18 16:50:52 UTC
[GitHub] brooklyn-library pull request: Avoid deadlock in AbstractGeoDnsSer...
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-library/pull/37
Avoid deadlock in AbstractGeoDnsServiceImpl
See commit message in 2e1246a for details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-library geoscaling2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-library/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
----
commit afbf8f1eb431de483ead2d18bcba35409087849d
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2016-05-18T16:38:47Z
Geoscaling improvements: newer APIs, null checks
commit 2e1246a8714422b21ab0262192837f6d31fd086b
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2016-05-18T16:46:43Z
AbstractGeoDnsServiceImpl uses own lock to guard tracker
Otherwise a deadlock is possible by -
Thread A:
Geoscaling.startTracker is synchronized on the entity
Calls config.get(CONFIG_KEY)
Dependent value set for config key
Brooklyn starts Thread B to resolve value.
Thread B:
Tries to get AbstractEntity.getExecutionContext,
which is also a method synchronized on the entity.
Blocks forever
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library issue #37: Avoid deadlock in AbstractGeoDnsServiceImpl
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/37
LGTM. Merging.
When hitting something serious such as a deadlock, I like to include a copy of the stacktraces in a jira issue (or at least in the comment of the pull request). That means it will be indexed by google, so anyone else who hits it with an older Brooklyn version can find details. But no need to do anything extra for this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request: Avoid deadlock in AbstractGeoDnsSer...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-library/pull/37#issuecomment-221836763
I also need to change `GeoscalingDnsServiceImpl` to not synchronise on the instance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request #37: Avoid deadlock in AbstractGeoDnsServiceIm...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-library/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---