[jira] [Commented] (THRIFT-2998) Node.js: Missing header from http request

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158185#comment-15158185 ] 

ASF GitHub Bot commented on THRIFT-2998:
----------------------------------------

Github user jfarrell commented on the pull request:

    https://github.com/apache/thrift/pull/378#issuecomment-187493321
  
    @RandyAbernethy agree with your suggested approach of committing this and creating a backlog story to tackle the larger IANA registered media type as a follow up


> Node.js: Missing header from http request
> -----------------------------------------
>
>                 Key: THRIFT-2998
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2998
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Library
>    Affects Versions: 0.9.2
>            Reporter: Traian Stanev
>
> The "Content-Type" header is not being set to "application/x-thrift" when making http requests in the node.js implementation. This results in error response (status 400) for any such connections (depending on whether the server checks the header). The Python implementation for example adds the header explicitly:
> https://github.com/tstanev/thrift/blob/master/lib/py/src/transport/THttpClient.py#L127



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)