You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2020/06/17 20:39:51 UTC

[arrow] branch master updated: ARROW-8892: [C++][CI] CI builds for MSVC do not build benchmarks

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 4d99ec4  ARROW-8892: [C++][CI] CI builds for MSVC do not build benchmarks
4d99ec4 is described below

commit 4d99ec48a0f36531124a368afe7818b56e25dfb3
Author: Krisztián Szűcs <sz...@gmail.com>
AuthorDate: Wed Jun 17 15:39:30 2020 -0500

    ARROW-8892: [C++][CI] CI builds for MSVC do not build benchmarks
    
    Set `ARROW_BUILD_BENCHMARKS` a windows build which is triggered on pull requests.
    
    (also ordered the passed flags alphabetically)
    
    Closes #7472 from kszucs/ARROW-8892
    
    Authored-by: Krisztián Szűcs <sz...@gmail.com>
    Signed-off-by: Wes McKinney <we...@apache.org>
---
 .github/workflows/cpp.yml | 35 ++++++++++++++++++-----------------
 1 file changed, 18 insertions(+), 17 deletions(-)

diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
index 0a7d3ad..d0b9a37 100644
--- a/.github/workflows/cpp.yml
+++ b/.github/workflows/cpp.yml
@@ -223,31 +223,32 @@ jobs:
             name: Windows 2019
             generator: Visual Studio 16 2019
     env:
-      CMAKE_ARGS: '-A x64 -DOPENSSL_ROOT_DIR=C:\Program Files\OpenSSL-Win64'
-      CMAKE_GENERATOR: ${{ matrix.generator }}
-      CMAKE_INSTALL_LIBDIR: bin
-      CMAKE_INSTALL_PREFIX: /usr
-      CMAKE_UNITY_BUILD: ON
-      ARROW_HOME: /usr
+      ARROW_BOOST_USE_SHARED: OFF
+      ARROW_BUILD_BENCHMARKS: ON
+      ARROW_BUILD_SHARED: ON
+      ARROW_BUILD_STATIC: OFF
+      ARROW_BUILD_TESTS: ON
       ARROW_DATASET: ON
-      ARROW_JEMALLOC: OFF
       ARROW_FLIGHT: OFF
       ARROW_HDFS: ON
+      ARROW_HOME: /usr
+      ARROW_JEMALLOC: OFF
       ARROW_MIMALLOC: ON
       ARROW_PARQUET: ON
-      ARROW_WITH_ZLIB: ON
-      ARROW_WITH_LZ4: OFF
-      ARROW_WITH_BZ2: OFF
-      ARROW_WITH_ZSTD: ON
-      ARROW_WITH_SNAPPY: ON
-      ARROW_WITH_BROTLI: OFF
       ARROW_USE_GLOG: OFF
-      ARROW_BUILD_TESTS: ON
-      ARROW_BUILD_SHARED: ON
-      ARROW_BUILD_STATIC: OFF
-      ARROW_BOOST_USE_SHARED: OFF
       ARROW_VERBOSE_THIRDPARTY_BUILD: OFF
+      ARROW_WITH_BROTLI: OFF
+      ARROW_WITH_BZ2: OFF
+      ARROW_WITH_LZ4: OFF
+      ARROW_WITH_SNAPPY: ON
+      ARROW_WITH_ZLIB: ON
+      ARROW_WITH_ZSTD: ON
       BOOST_SOURCE: BUNDLED
+      CMAKE_ARGS: '-A x64 -DOPENSSL_ROOT_DIR=C:\Program Files\OpenSSL-Win64'
+      CMAKE_GENERATOR: ${{ matrix.generator }}
+      CMAKE_INSTALL_LIBDIR: bin
+      CMAKE_INSTALL_PREFIX: /usr
+      CMAKE_UNITY_BUILD: ON
       NPROC: 2
     steps:
       - name: Disable Crash Dialogs