You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/11/30 16:33:06 UTC
Review Request 69493: Documented the `linux/seccomp` isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
Bugs: MESOS-9036
https://issues.apache.org/jira/browse/MESOS-9036
Repository: mesos
Description
-------
See summary.
Diffs
-----
docs/isolators/linux-seccomp.md PRE-CREATION
docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
Diff: https://reviews.apache.org/r/69493/diff/1/
Testing
-------
None: not a functional change.
Thanks,
Andrei Budnik
Re: Review Request 69493: Documented the `linux/seccomp` isolator.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review212372
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Nov. 30, 2018, 8:33 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2018, 8:33 a.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/isolators/linux-seccomp.md PRE-CREATION
> docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
> docs/upgrades.md e493aefb36ea7b9631af35179938d778dc47442a
>
>
> Diff: https://reviews.apache.org/r/69493/diff/6/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69493: Documented the `linux/seccomp` isolator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review211803
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 67844.
Failed command: `python.exe .\support\apply-reviews.py -n -r 67844`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2734/mesos-review-69493
Relevant logs:
- [apply-review-67844.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2734/mesos-review-69493/logs/apply-review-67844.log):
```
error: missing binary patch data for '3rdparty/libseccomp-2.3.3.tar.gz'
error: binary patch does not apply to '3rdparty/libseccomp-2.3.3.tar.gz'
error: 3rdparty/libseccomp-2.3.3.tar.gz: patch does not apply
```
- Mesos Reviewbot Windows
On Nov. 30, 2018, 4:33 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2018, 4:33 p.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/isolators/linux-seccomp.md PRE-CREATION
> docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
> docs/upgrades.md e493aefb36ea7b9631af35179938d778dc47442a
>
>
> Diff: https://reviews.apache.org/r/69493/diff/4/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69493: Documented the `linux/seccomp` isolator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review212153
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 67844.
Failed command: `python.exe .\support\apply-reviews.py -n -r 67844`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2803/mesos-review-69493
Relevant logs:
- [apply-review-67844.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2803/mesos-review-69493/logs/apply-review-67844.log):
```
error: missing binary patch data for '3rdparty/libseccomp-2.3.3.tar.gz'
error: binary patch does not apply to '3rdparty/libseccomp-2.3.3.tar.gz'
error: 3rdparty/libseccomp-2.3.3.tar.gz: patch does not apply
```
- Mesos Reviewbot Windows
On Nov. 30, 2018, 4:33 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2018, 4:33 p.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/isolators/linux-seccomp.md PRE-CREATION
> docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
> docs/upgrades.md e493aefb36ea7b9631af35179938d778dc47442a
>
>
> Diff: https://reviews.apache.org/r/69493/diff/6/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69493: Documented the `linux/seccomp` isolator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review211392
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 67844.
Failed command: `python.exe .\support\apply-reviews.py -n -r 67844`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2720/mesos-review-69493
Relevant logs:
- [apply-review-67844.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2720/mesos-review-69493/logs/apply-review-67844.log):
```
error: missing binary patch data for '3rdparty/libseccomp-2.3.3.tar.gz'
error: binary patch does not apply to '3rdparty/libseccomp-2.3.3.tar.gz'
error: 3rdparty/libseccomp-2.3.3.tar.gz: patch does not apply
```
- Mesos Reviewbot Windows
On Nov. 30, 2018, 4:33 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2018, 4:33 p.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/isolators/linux-seccomp.md PRE-CREATION
> docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
>
>
> Diff: https://reviews.apache.org/r/69493/diff/3/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69493: Documented the `linux/seccomp` isolator.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On Jan. 23, 2019, 7:26 a.m., Qian Zhang wrote:
> > docs/isolators/linux-seccomp.md
> > Lines 44 (patched)
> > <https://reviews.apache.org/r/69493/diff/6/?file=2120375#file2120375line44>
> >
> > <master ip>:5050 ?
I think it is just a snippet. No one will copy-paste blindly it ever.
I don't want to emphasize this insignificant detail (in the context of *seccomp* configuration) as a port which is also configurable.
> On Jan. 23, 2019, 7:26 a.m., Qian Zhang wrote:
> > docs/isolators/linux-seccomp.md
> > Lines 55 (patched)
> > <https://reviews.apache.org/r/69493/diff/6/?file=2120375#file2120375line55>
> >
> > I think we should mention `SeccompInfo` here.
From https://github.com/apache/mesos/blob/master/docs/isolators/linux-capabilities.md:
```
In order for a Mesos task to acquire specific effective capabilities or limit its bounding capabilities it should declare the required capabilities in the LinuxInfo element of its ContainerInfo.
```
This document has equivalent meaning in that sense. It should not be that hard for the reader to find `SeccompInfo` field in the `LinuxInfo` message.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review212225
-----------------------------------------------------------
On Nov. 30, 2018, 4:33 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2018, 4:33 p.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/isolators/linux-seccomp.md PRE-CREATION
> docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
> docs/upgrades.md e493aefb36ea7b9631af35179938d778dc47442a
>
>
> Diff: https://reviews.apache.org/r/69493/diff/6/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69493: Documented the `linux/seccomp` isolator.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review212225
-----------------------------------------------------------
Fix it, then Ship it!
docs/isolators/linux-seccomp.md
Lines 44 (patched)
<https://reviews.apache.org/r/69493/#comment297941>
<master ip>:5050 ?
docs/isolators/linux-seccomp.md
Lines 55 (patched)
<https://reviews.apache.org/r/69493/#comment297942>
I think we should mention `SeccompInfo` here.
- Qian Zhang
On Dec. 1, 2018, 12:33 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2018, 12:33 a.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/isolators/linux-seccomp.md PRE-CREATION
> docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
> docs/upgrades.md e493aefb36ea7b9631af35179938d778dc47442a
>
>
> Diff: https://reviews.apache.org/r/69493/diff/6/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69493: Documented the `linux/seccomp` isolator.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review211577
-----------------------------------------------------------
docs/isolators/linux-seccomp.md
Lines 10-11 (patched)
<https://reviews.apache.org/r/69493/#comment296936>
Can we merge these two lines into one?
docs/isolators/linux-seccomp.md
Lines 31 (patched)
<https://reviews.apache.org/r/69493/#comment296938>
s/processes/process/
- Qian Zhang
On Dec. 1, 2018, 12:33 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2018, 12:33 a.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/isolators/linux-seccomp.md PRE-CREATION
> docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
>
>
> Diff: https://reviews.apache.org/r/69493/diff/3/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69493: Documented the `linux/seccomp` isolator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review211040
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 67844.
Failed command: `python.exe .\support\apply-reviews.py -n -r 67844`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2670/mesos-review-69493
Relevant logs:
- [apply-review-67844.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2670/mesos-review-69493/logs/apply-review-67844.log):
```
error: missing binary patch data for '3rdparty/libseccomp-2.3.3.tar.gz'
error: binary patch does not apply to '3rdparty/libseccomp-2.3.3.tar.gz'
error: 3rdparty/libseccomp-2.3.3.tar.gz: patch does not apply
```
- Mesos Reviewbot Windows
On Nov. 30, 2018, 4:33 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2018, 4:33 p.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/isolators/linux-seccomp.md PRE-CREATION
> docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
>
>
> Diff: https://reviews.apache.org/r/69493/diff/2/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69493: Documented the `linux/seccomp` isolator.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On Jan. 25, 2019, 10 a.m., Gilbert Song wrote:
> > Mesos is not responsible for packaging, which means that Mesos does not provide a default seccomp config. However, it may be hard for many operators to figure out a common seccomp profile on Mesos. Could we add a recommended seccomp profile in this doc?
The main reason we might not want to provide a default seccomp config here is that it will eventually become outdated. Given that it's a security feature, recommending an outdated profile does not look good to me.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review212317
-----------------------------------------------------------
On Nov. 30, 2018, 4:33 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2018, 4:33 p.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/isolators/linux-seccomp.md PRE-CREATION
> docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
> docs/upgrades.md e493aefb36ea7b9631af35179938d778dc47442a
>
>
> Diff: https://reviews.apache.org/r/69493/diff/6/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69493: Documented the `linux/seccomp` isolator.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review212317
-----------------------------------------------------------
Mesos is not responsible for packaging, which means that Mesos does not provide a default seccomp config. However, it may be hard for many operators to figure out a common seccomp profile on Mesos. Could we add a recommended seccomp profile in this doc?
- Gilbert Song
On Nov. 30, 2018, 8:33 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2018, 8:33 a.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/isolators/linux-seccomp.md PRE-CREATION
> docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
> docs/upgrades.md e493aefb36ea7b9631af35179938d778dc47442a
>
>
> Diff: https://reviews.apache.org/r/69493/diff/6/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69493: Documented the `linux/seccomp` isolator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review210976
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 67844.
Failed command: `python.exe .\support\apply-reviews.py -n -r 67844`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2664/mesos-review-69493
Relevant logs:
- [apply-review-67844.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2664/mesos-review-69493/logs/apply-review-67844.log):
```
error: missing binary patch data for '3rdparty/libseccomp-2.3.3.tar.gz'
error: binary patch does not apply to '3rdparty/libseccomp-2.3.3.tar.gz'
error: 3rdparty/libseccomp-2.3.3.tar.gz: patch does not apply
```
- Mesos Reviewbot Windows
On Nov. 30, 2018, 4:33 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2018, 4:33 p.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/isolators/linux-seccomp.md PRE-CREATION
> docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
>
>
> Diff: https://reviews.apache.org/r/69493/diff/1/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69493: Documented the `linux/seccomp` isolator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review212067
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 67844.
Failed command: `python.exe .\support\apply-reviews.py -n -r 67844`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2790/mesos-review-69493
Relevant logs:
- [apply-review-67844.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2790/mesos-review-69493/logs/apply-review-67844.log):
```
error: missing binary patch data for '3rdparty/libseccomp-2.3.3.tar.gz'
error: binary patch does not apply to '3rdparty/libseccomp-2.3.3.tar.gz'
error: 3rdparty/libseccomp-2.3.3.tar.gz: patch does not apply
```
- Mesos Reviewbot Windows
On Nov. 30, 2018, 4:33 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2018, 4:33 p.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/isolators/linux-seccomp.md PRE-CREATION
> docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
> docs/upgrades.md e493aefb36ea7b9631af35179938d778dc47442a
>
>
> Diff: https://reviews.apache.org/r/69493/diff/5/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69493: Documented the `linux/seccomp` isolator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review211048
-----------------------------------------------------------
Bad patch!
Reviews applied: [69493, 69420, 69409, 68022, 68021, 68020, 68019, 68018, 68017, 68016, 67844]
Failed command: /usr/bin/python3 support/apply-reviews.py -n -r 67844
Error:
2018-12-05 18:22:11 URL:https://reviews.apache.org/r/67844/diff/raw/ [260/260] -> "67844.patch" [1]
error: missing binary patch data for '3rdparty/libseccomp-2.3.3.tar.gz'
error: binary patch does not apply to '3rdparty/libseccomp-2.3.3.tar.gz'
error: 3rdparty/libseccomp-2.3.3.tar.gz: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/23592/console
- Mesos Reviewbot
On Nov. 30, 2018, 4:33 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2018, 4:33 p.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/isolators/linux-seccomp.md PRE-CREATION
> docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
>
>
> Diff: https://reviews.apache.org/r/69493/diff/2/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69493: Documented the `linux/seccomp` isolator.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review211538
-----------------------------------------------------------
docs/mesos-containerizer.md
Lines 52 (patched)
<https://reviews.apache.org/r/69493/#comment296865>
I think we also need to update the `upgrades.md` like https://github.com/apache/mesos/blob/master/docs/upgrades.md#1-5-x-network-ports-isolator
- Qian Zhang
On Dec. 1, 2018, 12:33 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2018, 12:33 a.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/isolators/linux-seccomp.md PRE-CREATION
> docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e
>
>
> Diff: https://reviews.apache.org/r/69493/diff/3/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>