[GitHub] [activemq-artemis] jbertram commented on a diff in pull request #4433: [ARTEMIS-4238]: transaction-timeout ActivationConfigProperty is no lo…

["jbertram (via GitHub)" <gi...@apache.org>]

jbertram commented on code in PR #4433:
URL: https://github.com/apache/activemq-artemis/pull/4433#discussion_r1163154561


##########
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRAManagedConnection.java:
##########
@@ -336,7 +336,7 @@ public void associateConnection(final Object obj) throws ResourceException {
 
    public void checkTransactionActive() throws JMSException {
       // don't bother looking at the transaction if there's an active XID
-      if (!inManagedTx && tsr != null) {
+      if (!inManagedTx && tsr != null && tsr.getTransactionKey() != null) {

Review Comment:
   This change doesn't appear related to the `transactionTimeout` change. Why is this necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org