You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/10/01 23:07:35 UTC
[GitHub] [openwhisk] codecov-io edited a comment on issue #4659: add config
to allow removal of Activation result before storing in some cases
codecov-io edited a comment on issue #4659: add config to allow removal of Activation result before storing in some cases
URL: https://github.com/apache/openwhisk/pull/4659#issuecomment-537268111
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4659?src=pr&el=h1) Report
> Merging [#4659](https://codecov.io/gh/apache/openwhisk/pull/4659?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/3f9a78035d7c3be08d3e3e3c2e783ab5d3530ec7?src=pr&el=desc) will **decrease** coverage by `4.61%`.
> The diff coverage is `96.49%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/openwhisk/pull/4659/graphs/tree.svg?width=650&token=l0YmsiSAso&height=150&src=pr)](https://codecov.io/gh/apache/openwhisk/pull/4659?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4659 +/- ##
==========================================
- Coverage 83.12% 78.51% -4.62%
==========================================
Files 184 184
Lines 8438 8465 +27
Branches 591 579 -12
==========================================
- Hits 7014 6646 -368
- Misses 1424 1819 +395
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4659?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../scala/org/apache/openwhisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4659/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `94.81% <100%> (+0.03%)` | :arrow_up: |
| [...org/apache/openwhisk/core/controller/Actions.scala](https://codecov.io/gh/apache/openwhisk/pull/4659/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9BY3Rpb25zLnNjYWxh) | `93.03% <100%> (+1.53%)` | :arrow_up: |
| [...abase/ArtifactWithFileStorageActivationStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4659/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvQXJ0aWZhY3RXaXRoRmlsZVN0b3JhZ2VBY3RpdmF0aW9uU3RvcmUuc2NhbGE=) | `90.9% <100%> (-0.76%)` | :arrow_down: |
| [...rpool/logging/DockerToActivationFileLogStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4659/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9sb2dnaW5nL0RvY2tlclRvQWN0aXZhdGlvbkZpbGVMb2dTdG9yZS5zY2FsYQ==) | `68.08% <100%> (ø)` | :arrow_up: |
| [...hisk/core/controller/actions/SequenceActions.scala](https://codecov.io/gh/apache/openwhisk/pull/4659/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1NlcXVlbmNlQWN0aW9ucy5zY2FsYQ==) | `92.5% <100%> (+9.74%)` | :arrow_up: |
| [.../apache/openwhisk/core/controller/WebActions.scala](https://codecov.io/gh/apache/openwhisk/pull/4659/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9XZWJBY3Rpb25zLnNjYWxh) | `92.33% <100%> (+2.41%)` | :arrow_up: |
| [.../org/apache/openwhisk/core/connector/Message.scala](https://codecov.io/gh/apache/openwhisk/pull/4659/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `76.72% <100%> (+12.06%)` | :arrow_up: |
| [...core/controller/actions/PostActionActivation.scala](https://codecov.io/gh/apache/openwhisk/pull/4659/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1Bvc3RBY3Rpb25BY3RpdmF0aW9uLnNjYWxh) | `100% <100%> (ø)` | :arrow_up: |
| [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/openwhisk/pull/4659/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `87.89% <100%> (+2.66%)` | :arrow_up: |
| [.../openwhisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/openwhisk/pull/4659/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `93.04% <100%> (+0.53%)` | :arrow_up: |
| ... and [42 more](https://codecov.io/gh/apache/openwhisk/pull/4659/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4659?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4659?src=pr&el=footer). Last update [3f9a780...12766aa](https://codecov.io/gh/apache/openwhisk/pull/4659?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services