[GitHub] [kafka] dejan2609 commented on a diff in pull request #13205: KAFKA-14680: Upgrade gradle version from 7.6 to 8.0.1

["dejan2609 (via GitHub)" <gi...@apache.org>]

dejan2609 commented on code in PR #13205:
URL: https://github.com/apache/kafka/pull/13205#discussion_r1116336908


##########
gradlew:
##########
@@ -32,10 +32,10 @@
 #       Busybox and similar reduced shells will NOT work, because this script
 #       requires all of these POSIX shell features:
 #         * functions;
-#         * expansions «$var», «${var}», «${var:-default}», «${var+SET}»,
-#           «${var#prefix}», «${var%suffix}», and «$( cmd )»;
-#         * compound commands having a testable exit status, especially «case»;
-#         * various built-in commands including «command», «set», and «ulimit».
+#         * expansions �$var�, �${var}�, �${var:-default}�, �${var+SET}�,
+#           �${var#prefix}�, �${var%suffix}�, and �$( cmd )�;
+#         * compound commands having a testable exit status, especially �case�;
+#         * various built-in commands including �command�, �set�, and �ulimit�.

Review Comment:
   From the top of my head this may be related with zero width characters or something od that sort (https://github.com/microsoft/terminal/issues/11850) 
   
   Thing is that I am constantly switching from Windows to Linux and back, and this commit was created in Windows.
   
   In any case, thank you for solving this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org