You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by sy...@apache.org on 2022/01/25 13:09:30 UTC
[zookeeper] branch branch-3.6 updated: ZOOKEEPER-3988: rg.apache.zookeeper.server.NettyServerCnxn.receiveMessage throws NullPointerException
This is an automated email from the ASF dual-hosted git repository.
symat pushed a commit to branch branch-3.6
in repository https://gitbox.apache.org/repos/asf/zookeeper.git
The following commit(s) were added to refs/heads/branch-3.6 by this push:
new 357e88c ZOOKEEPER-3988: rg.apache.zookeeper.server.NettyServerCnxn.receiveMessage throws NullPointerException
357e88c is described below
commit 357e88c1438780e28d36bf54784937e18547e136
Author: Enrico Olivelli <eo...@apache.org>
AuthorDate: Tue Jan 25 12:48:34 2022 +0000
ZOOKEEPER-3988: rg.apache.zookeeper.server.NettyServerCnxn.receiveMessage throws NullPointerException
Modifications:
- prevent the NPE, the code that throws NPE is only to record some metrics for non TLS requests
Related to:
- apache/pulsar#11070
- https://github.com/pravega/zookeeper-operator/issues/393
Author: Enrico Olivelli <eo...@apache.org>
Reviewers: Nicolo² Boschi <bo...@gmail.com>, Andor Molnar <an...@apache.org>, Mate Szalay-Beko <sy...@apache.org>
Closes #1798 from eolivelli/fix/ZOOKEEPER-3988-npe
(cherry picked from commit 957f8fc0afbeca638f13f6fb739e49a921da2b9d)
Signed-off-by: Mate Szalay-Beko <sy...@apache.org>
---
.../zookeeper/server/NettyServerCnxnFactory.java | 18 ++++++++++-----
.../zookeeper/server/NettyServerCnxnTest.java | 26 +++++++++++++++-------
.../apache/zookeeper/server/TxnLogCountTest.java | 2 +-
3 files changed, 31 insertions(+), 15 deletions(-)
diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java b/zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
index 6416cf0..0729fb5 100644
--- a/zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
+++ b/zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
@@ -250,14 +250,20 @@ public class NettyServerCnxnFactory extends ServerCnxnFactory {
allChannels.add(ctx.channel());
addCnxn(cnxn);
}
+
if (ctx.channel().pipeline().get(SslHandler.class) == null) {
- SocketAddress remoteAddress = cnxn.getChannel().remoteAddress();
- if (remoteAddress != null
- && !((InetSocketAddress) remoteAddress).getAddress().isLoopbackAddress()) {
- LOG.trace("NettyChannelHandler channelActive: remote={} local={}", remoteAddress, cnxn.getChannel().localAddress());
- zkServer.serverStats().incrementNonMTLSRemoteConnCount();
+ if (zkServer != null) {
+ SocketAddress remoteAddress = cnxn.getChannel().remoteAddress();
+ if (remoteAddress != null
+ && !((InetSocketAddress) remoteAddress).getAddress().isLoopbackAddress()) {
+ LOG.trace("NettyChannelHandler channelActive: remote={} local={}", remoteAddress, cnxn.getChannel().localAddress());
+ zkServer.serverStats().incrementNonMTLSRemoteConnCount();
+ } else {
+ zkServer.serverStats().incrementNonMTLSLocalConnCount();
+ }
} else {
- zkServer.serverStats().incrementNonMTLSLocalConnCount();
+ LOG.trace("Opened non-TLS connection from {} but zkServer is not running",
+ cnxn.getChannel().remoteAddress());
}
}
}
diff --git a/zookeeper-server/src/test/java/org/apache/zookeeper/server/NettyServerCnxnTest.java b/zookeeper-server/src/test/java/org/apache/zookeeper/server/NettyServerCnxnTest.java
index 0d98e21..abd687b 100644
--- a/zookeeper-server/src/test/java/org/apache/zookeeper/server/NettyServerCnxnTest.java
+++ b/zookeeper-server/src/test/java/org/apache/zookeeper/server/NettyServerCnxnTest.java
@@ -165,9 +165,22 @@ public class NettyServerCnxnTest extends ClientBase {
}
}
- @SuppressWarnings("unchecked")
@Test
public void testNonMTLSRemoteConn() throws Exception {
+ LeaderZooKeeperServer zks = mock(LeaderZooKeeperServer.class);
+ when(zks.isRunning()).thenReturn(true);
+ ServerStats.Provider providerMock = mock(ServerStats.Provider.class);
+ when(zks.serverStats()).thenReturn(new ServerStats(providerMock));
+ testNonMTLSRemoteConn(zks);
+ }
+
+ @Test
+ public void testNonMTLSRemoteConnZookKeeperServerNotReady() throws Exception {
+ testNonMTLSRemoteConn(null);
+ }
+
+ @SuppressWarnings("unchecked")
+ private void testNonMTLSRemoteConn(ZooKeeperServer zks) throws Exception {
Channel channel = mock(Channel.class);
ChannelId id = mock(ChannelId.class);
ChannelFuture success = mock(ChannelFuture.class);
@@ -183,21 +196,18 @@ public class NettyServerCnxnTest extends ClientBase {
when(channel.remoteAddress()).thenReturn(address);
when(channel.id()).thenReturn(id);
NettyServerCnxnFactory factory = new NettyServerCnxnFactory();
- LeaderZooKeeperServer zks = mock(LeaderZooKeeperServer.class);
factory.setZooKeeperServer(zks);
Attribute atr = mock(Attribute.class);
Mockito.doReturn(atr).when(channel).attr(
Mockito.any()
);
doNothing().when(atr).set(Mockito.any());
-
- ServerStats.Provider providerMock = mock(ServerStats.Provider.class);
- when(zks.serverStats()).thenReturn(new ServerStats(providerMock));
-
factory.channelHandler.channelActive(context);
- assertEquals(0, zks.serverStats().getNonMTLSLocalConnCount());
- assertEquals(1, zks.serverStats().getNonMTLSRemoteConnCount());
+ if (zks != null) {
+ assertEquals(0, zks.serverStats().getNonMTLSLocalConnCount());
+ assertEquals(1, zks.serverStats().getNonMTLSRemoteConnCount());
+ }
}
@Test
diff --git a/zookeeper-server/src/test/java/org/apache/zookeeper/server/TxnLogCountTest.java b/zookeeper-server/src/test/java/org/apache/zookeeper/server/TxnLogCountTest.java
index afcb09b..4ae6cbd 100644
--- a/zookeeper-server/src/test/java/org/apache/zookeeper/server/TxnLogCountTest.java
+++ b/zookeeper-server/src/test/java/org/apache/zookeeper/server/TxnLogCountTest.java
@@ -18,7 +18,7 @@
package org.apache.zookeeper.server;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.Assert.assertEquals;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.doAnswer;