You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@spark.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2024/01/10 01:56:00 UTC

[jira] [Updated] (SPARK-46644) Fix add in SQLMetric

     [ https://issues.apache.org/jira/browse/SPARK-46644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated SPARK-46644:
-----------------------------------
    Labels: pull-request-available  (was: )

> Fix add in SQLMetric
> --------------------
>
>                 Key: SPARK-46644
>                 URL: https://issues.apache.org/jira/browse/SPARK-46644
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 3.5.0
>            Reporter: Davin Tjong
>            Priority: Major
>              Labels: pull-request-available
>
> A previous refactor mistakenly used `isValid` for add. Since `defaultValidValue` was always `0`, this didn't cause any correctness issues.
> What we really want to do for add (and merge) is `if (isZero) _value = 0`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org