[GitHub] [ozone] yuangu002 commented on pull request #2539: HDDS-5616. [Dev Support] Add a shell script to automate docker-up with FSO-enabled

[GitBox <gi...@apache.org>]

yuangu002 commented on pull request #2539:
URL: https://github.com/apache/ozone/pull/2539#issuecomment-900512878


   > Thanks @yuangu002 for thinking about improving developer experience.
   > 
   > I don't think we need a separate script for such logic. It definitely does not belong to the root directory and README, since it is specific to the `ozone` compose environment.
   > 
   > Instead of adding the new script, we can define these variables in existing `run.sh` for documentation purpose. We may also consider enabling FSO as default in `run.sh`.
   > 
   > https://github.com/apache/ozone/blob/master/hadoop-ozone/dist/src/main/compose/ozone/run.sh
   
   Thanks @adoroszlai for taking a look. I have reverted back all root directory level changes. Could you take another look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org