[GitHub] [zookeeper] anmolnar commented on a change in pull request #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property

[GitBox <gi...@apache.org>]

anmolnar commented on a change in pull request #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property
URL: https://github.com/apache/zookeeper/pull/1034#discussion_r322682677
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java
 ##########
 @@ -120,6 +124,23 @@ public ZKDatabase(FileTxnSnapLog snapLog) {
             snapshotSizeFactor = DEFAULT_SNAPSHOT_SIZE_FACTOR;
         }
         LOG.info("{} = {}", SNAPSHOT_SIZE_FACTOR, snapshotSizeFactor);
+
+        try {
+            commitLogCount = Integer.parseInt(
+                    System.getProperty(COMMIT_LOG_COUNT,
+                            Integer.toString(DEFAULT_COMMIT_LOG_COUNT)));
+            if (commitLogCount < DEFAULT_COMMIT_LOG_COUNT) {
+                commitLogCount = DEFAULT_COMMIT_LOG_COUNT;
+                LOG.warn("The configured commitLogCount {} is less than the recommended {}"
 
 Review comment:
   I think this would have been added to the documentation. The default value of 500 is not just a default value, but the minimum and the recommended one. What's the risk of setting this to less than 500 btw?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services