You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Daniel Gornstein <dg...@mitre.org> on 2013/01/11 16:55:04 UTC

Review Request: Rave 871 - Adding in logging statements to page controller

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8928/
-----------------------------------------------------------

Review request for rave.


Description
-------

Adding in more logging statements to page controller


Diffs
-----


Diff: https://reviews.apache.org/r/8928/diff/


Testing
-------


Thanks,

Daniel Gornstein


Re: Review Request: Rave 871 - Adding in logging statements to page controller

Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8928/#review15335
-----------------------------------------------------------


Can you upload the diff for this review?

- Matt Franklin


On Jan. 11, 2013, 3:55 p.m., Daniel Gornstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8928/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2013, 3:55 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Adding in more logging statements to page controller
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/8928/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Gornstein
> 
>


Re: Review Request: Rave 871 - Adding in logging statements to page controller

Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8928/#review15570
-----------------------------------------------------------



trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java
<https://reviews.apache.org/r/8928/#comment33651>

    This seems like a tactical log statement that is attempting to identify a problem in your environment.  Can you share what that issue is?  There might be a better way to approach this.


- Matt Franklin


On Jan. 15, 2013, 1:45 p.m., Daniel Gornstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8928/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2013, 1:45 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Adding in more logging statements to page controller
> 
> 
> Diffs
> -----
> 
>   trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1430296 
> 
> Diff: https://reviews.apache.org/r/8928/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Gornstein
> 
>


Re: Review Request: Rave 871 - Adding in logging statements to page controller

Posted by Daniel Gornstein <dg...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8928/
-----------------------------------------------------------

(Updated Jan. 15, 2013, 1:45 p.m.)


Review request for rave.


Changes
-------

Adding diff


Description
-------

Adding in more logging statements to page controller


Diffs (updated)
-----

  trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1430296 

Diff: https://reviews.apache.org/r/8928/diff/


Testing
-------


Thanks,

Daniel Gornstein