[GitHub] [solr] janhoy commented on pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

[GitBox <gi...@apache.org>]

janhoy commented on pull request #553:
URL: https://github.com/apache/solr/pull/553#issuecomment-1018268865


   I wish we did not need to add licenses for test-dependencies (https://issues.apache.org/jira/browse/SOLR-15465), it just creates noise that makes it harder to understand what runtime dependencies we are actually adding in the binary distro.
   
   Do you perhaps have a list of actual added runtime deps/jars as well?
   
   Looks fishy to have different versions of `io.netty:netty` and `io.netty:netty-all`. Also, our build already contains tons of netty deps, so could be you can exclude netty-all and hadoop would still be happy. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org