[GitHub] [arrow-datafusion] mustafasrepo commented on a diff in pull request #6652: fix: handle no_used_column Window push_down_projection

["mustafasrepo (via GitHub)" <gi...@apache.org>]

mustafasrepo commented on code in PR #6652:
URL: https://github.com/apache/arrow-datafusion/pull/6652#discussion_r1227544034


##########
datafusion/core/tests/sqllogictests/test_files/window.slt:
##########
@@ -258,34 +258,37 @@ Sort: d.b ASC NULLS LAST
 ----Aggregate: groupBy=[[d.b]], aggr=[[MAX(d.a)]]
 ------SubqueryAlias: d
 --------SubqueryAlias: _data2
-----------SubqueryAlias: s
-------------SubqueryAlias: _sample_data

Review Comment:
   > Isn't the new plan worse? Previously there is no `WindowAggr` because `seq is not used in the outer query's select list:
   > 
   > ```sql
   > SELECT d.b, MAX(d.a) AS max_a
   > ```
   
   I agree with this observation, also comment in the test (`# window expr is not referenced anywhere, eliminate it.`) suggests that this is the desired behavior and intentional



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org